From: Jaime Arrocha <jarrocha@kerneldev.net>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Jaime Arrocha <jarr@kerneldev.net>,
greg@kroah.com, abbotti@mev.co.uk, hsweeten@visionengravers.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: comedi: coding style identation error fix
Date: Thu, 07 May 2015 09:36:52 -0500 [thread overview]
Message-ID: <554B7884.90002@kerneldev.net> (raw)
In-Reply-To: <20150507131658.GA15680@sudip-PC>
On 05/07/2015 08:21 AM, Sudip Mukherjee wrote:
> On Thu, May 07, 2015 at 08:01:53AM -0500, Jaime Arrocha wrote:
>>
>>
>> On 05/07/2015 12:34 AM, Sudip Mukherjee wrote:
>>> On Wed, May 06, 2015 at 05:13:41PM -0500, Jaime Arrocha wrote:
>>>> Errors found by checkpatch.pl.
>>>> ERROR: code indent should use tabs where possible
>>>> /drivers/staging/comedi/drivers/das16m1.c:49
>>>> /drivers/staging/comedi/drivers/das16m1.c:50
>>>>
>>>> Signed-off-by: Jaime Arrocha <jarr@kerneldev.net>
>>>> ---
>>> you are sending this patch second time with different subject.
>>> any reason for that?
>>>
>>> regards
>>> sudip
>>>
>>
>> Yes, the first one had the subject line too long and not clear.
>> When I need to resend a patch like I did, should I add on the second
>> one the reason behind resending and dismissing the first one? Thank
>> you.
>
> first of all you should reply to the first patch stating that should not
> be applied and that you have sent a second patch. And this one should
> have had a v2 in the subject with the reason of v2 below the --- cutoff.
> since you have already sent the second patch just reply to the fist
> patch as of now.
> And you have sent the patches to greg@kroah.com, it should have been
> gregkh@linuxfoundation.org . always use get_maintainer.pl to see whom
> to send patches.
>
> regards
> sudip
>
>
Thanks Sudip, I will dismiss this one too and do it correctly. I
accidentally took Greg's email from the TODO file.
This patch should not be applied.
Thanks,
jaime
prev parent reply other threads:[~2015-05-07 14:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 22:13 [PATCH] staging: comedi: coding style identation error fix Jaime Arrocha
2015-05-07 5:34 ` Sudip Mukherjee
2015-05-07 13:01 ` Jaime Arrocha
2015-05-07 13:21 ` Sudip Mukherjee
2015-05-07 14:36 ` Jaime Arrocha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554B7884.90002@kerneldev.net \
--to=jarrocha@kerneldev.net \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=hsweeten@visionengravers.com \
--cc=jarr@kerneldev.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.