All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Michal Suchanek <hramrach@gmail.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	David Vrabel <david.vrabel@citrix.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
	xen-devel@lists.xenproject.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: problem building on ARM with XEN enabled
Date: Thu, 07 May 2015 11:24:03 -0400	[thread overview]
Message-ID: <554B8393.1050103@oracle.com> (raw)
In-Reply-To: <CAOMqctSxB+HaunosrZG1gVcvCAuZ5SGitgQp2SttXZh2eMgQng@mail.gmail.com>

On 05/07/2015 11:10 AM, Michal Suchanek wrote:
> Hello,
>
> it appears the Linus master tree fails to build on ARM with XEN enabled.
>
> Since commit 2b953a5e9 xen: Suspend ticks on all CPUs during suspend
>
> provides the suspend function only for x86 this is not surprising.
>
> I currently don't use XEN yet but building with XEN enabled was not a
> problem in the past so this looks like a regression to me.



(+Stefano)

Does this fix it:

diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
index 224081c..7d0f070 100644
--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -272,6 +272,7 @@ void xen_arch_pre_suspend(void) { }
  void xen_arch_post_suspend(int suspend_cancelled) { }
  void xen_timer_resume(void) { }
  void xen_arch_resume(void) { }
+void xen_arch_suspend(void) { }


  /* In the hypervisor.S file. */


  reply	other threads:[~2015-05-07 15:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-07 15:10 problem building on ARM with XEN enabled Michal Suchanek
2015-05-07 15:24 ` Boris Ostrovsky [this message]
2015-05-07 16:37   ` Stefano Stabellini
2015-05-07 16:37   ` Stefano Stabellini
2015-05-07 15:24 ` Boris Ostrovsky
  -- strict thread matches above, loose matches on Subject: below --
2015-05-07 15:10 Michal Suchanek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554B8393.1050103@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=david.vrabel@citrix.com \
    --cc=hpa@zytor.com \
    --cc=hramrach@gmail.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.