From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v2 7/8] xenalyze: remove traling whitespaces Date: Thu, 7 May 2015 18:34:29 +0100 Message-ID: <554BA225.2010008@eu.citrix.com> References: <1430994944-20471-1-git-send-email-olaf@aepfle.de> <1430994944-20471-8-git-send-email-olaf@aepfle.de> <554BA059.2020708@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <554BA059.2020708@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , Olaf Hering , xen-devel@lists.xen.org Cc: Ian Jackson , Wei Liu , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 05/07/2015 06:26 PM, Andrew Cooper wrote: > On 07/05/15 11:35, Olaf Hering wrote: >> Result of "sed -i 's@[[:blank:]]\+$@@' tools/xentrace/xenalyze/xenalyze.c" >> >> Signed-off-by: Olaf Hering >> Cc: Ian Jackson >> Cc: Stefano Stabellini >> Cc: Ian Campbell >> Cc: Wei Liu > > Why not refresh patch 1 using git's --whitespace=fix mode? It would > save adding whitespace just to remove it again, and also fix up the > other imported files. Presumably he was trying to be diligent about making sure he checked in exactly what was in the repo? I'm fine with Andrew's suggestion, FWIW. -George