From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 1/5] xen/vm_event: Added support for XSETBV events Date: Thu, 7 May 2015 18:44:42 +0100 Message-ID: <554BA48A.5070308@citrix.com> References: <1430932352-4289-1-git-send-email-rcojocaru@bitdefender.com> <1430932352-4289-2-git-send-email-rcojocaru@bitdefender.com> <20150507154357.GL40948@deinos.phlegethon.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150507154357.GL40948@deinos.phlegethon.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tim Deegan , Razvan Cojocaru Cc: kevin.tian@intel.com, keir@xen.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, jun.nakajima@intel.com, eddie.dong@intel.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, Aravind.Gopalakrishnan@amd.com, jbeulich@suse.com, wei.liu2@citrix.com, boris.ostrovsky@oracle.com, suravee.suthikulpanit@amd.com List-Id: xen-devel@lists.xenproject.org On 07/05/15 16:43, Tim Deegan wrote: > At 20:12 +0300 on 06 May (1430943148), Razvan Cojocaru wrote: >> This patch adds XSETBV (XCR) vm_events. >> >> Signed-off-by: Razvan Cojocaru > After making things more architecture-neutral in the API rework, it > seems a shame to have this called 'xsetbv'. But since we already have > CR0 etc in this interface, I guess that's OK. > > Acked-by: Tim Deegan While we are still in the period of ABI flux, might it be appropriate to take the cleanup one step further and separate the common ABI/API from architecture specific bits? e.g. split public/vm_event.h to have arch-x86/vm_event.h as well, and declare VM_EVENT_REASON_ARCH starting at 0x80000000 or so? The x86 specific structures can become vm_event_x86_$foo. It seems worthwhile, and we have until 4.6 is released to make changes like this. ~Andrew