All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com>,
	qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, quintela@redhat.com,
	dgilbert@redhat.com, stefanha@redhat.com, pbonzini@redhat.com,
	amit.shah@redhat.com, den@openvz.org
Subject: Re: [Qemu-devel] [PATCH RFC v4 10/13] iotests: add event_wait to VM class
Date: Thu, 07 May 2015 15:45:02 -0400	[thread overview]
Message-ID: <554BC0BE.1010901@redhat.com> (raw)
In-Reply-To: <1425057891-29848-11-git-send-email-vsementsov@parallels.com>



On 02/27/2015 12:24 PM, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: John Snow <jsnow@redhat.com>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com>
> ---
>  tests/qemu-iotests/iotests.py | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> index 75640b2..294b158 100644
> --- a/tests/qemu-iotests/iotests.py
> +++ b/tests/qemu-iotests/iotests.py
> @@ -203,6 +203,13 @@ class VM(object):
>          self._qmp.clear_events()
>          return events
>  
> +    def event_wait(self, name='BLOCK_JOB_COMPLETED', maxwait=10):
> +        for _ in range(maxwait):
> +            for event in self.get_qmp_events(wait=True):
> +                if event['event'] == name:
> +                    return event
> +            return None
> +
>  index_re = re.compile(r'([^\[]+)\[([^\]]+)\]')
>  
>  class QMPTestCase(unittest.TestCase):
> 

For v5, I have already included this upstream and expanded it slightly
to include a proper timeout mechanism as well as a new "match" parameter
that accepts a dict that can be used as a "filter" to only select events
for which 'match' is a recursive subset.

This patch can likely be dropped again.

  reply	other threads:[~2015-05-07 19:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-27 17:24 [Qemu-devel] [PATCH RFC v4 00/13] Dirty bitmaps migration Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 01/13] hbitmap: serialization Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 02/13] block: BdrvDirtyBitmap serialization interface Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 03/13] block: tiny refactoring: minimize hbitmap_(set/reset) usage Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 04/13] block: add meta bitmaps Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 05/13] block: add bdrv_next_dirty_bitmap() Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 06/13] qapi: add dirty-bitmaps migration capability Vladimir Sementsov-Ogievskiy
2015-02-27 18:29   ` Eric Blake
2015-03-02 10:02     ` Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 07/13] migration: add migration/block-dirty-bitmap.c Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 08/13] iotests: maintain several vms in test Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 09/13] iotests: add add_incoming_migration to VM class Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 10/13] iotests: add event_wait " Vladimir Sementsov-Ogievskiy
2015-05-07 19:45   ` John Snow [this message]
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 11/13] qapi: add md5 checksum of last dirty bitmap level to query-block Vladimir Sementsov-Ogievskiy
2015-02-27 18:32   ` Eric Blake
2015-02-27 20:08     ` John Snow
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 12/13] iotests: add dirty bitmap migration test Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 13/13] migration/qemu-file: make functions qemu_(get/put)_string public Vladimir Sementsov-Ogievskiy
2015-02-27 20:13 ` [Qemu-devel] [PATCH RFC v4 00/13] Dirty bitmaps migration John Snow
2015-03-02 10:30   ` Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554BC0BE.1010901@redhat.com \
    --to=jsnow@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=den@openvz.org \
    --cc=dgilbert@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.