From: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: iw_cxgb4: use wildcard mapping for getting remote addr info
Date: Thu, 07 May 2015 16:00:50 -0500 [thread overview]
Message-ID: <554BD282.7060800@opengridcomputing.com> (raw)
In-Reply-To: <20150507204508.GA1195-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
On 5/7/2015 3:45 PM, Jason Gunthorpe wrote:
> On Thu, May 07, 2015 at 09:52:24AM -0500, Steve Wise wrote:
>> For listening endpoints bound to the wildcard address, we need to pass
>> the wildcard address mapping to iwpm_get_remote_info() instead of the
>> mapped address of the new child connection.
> It would be nice to see a discussion about what bug this fixes in the
> commit message...
>
> So we can answer the question: Does this need to go to -stable?
>
Without this fix, and with iwarp port mapping enabled, each iw_cxgb4
connection that is spawned from a listening endpoint bound to the
wildcard address, will generate an annoying dmesg entry about failing to
find the remote address mapping info, and the connection state displayed
in debugfs under /sys/kernel/debug/iw_cxgb4/<pci-slot-no>/eps will not
have the peer's address/port mapping info. The connection still works
though.
This does not need to hit stable because the remote_info logic was just
added in 4.1 with:
---
commit 5b6b8fe64053b2649660ded2f3c5be25ebddbfdb
Author: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Date: Tue Apr 21 16:28:41 2015 -0400
RDMA/cxgb4: Report the actual address of the remote connecting peer
---
Doug, shall I resend the patch with an updated comment?
Steve.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-05-07 21:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 14:52 [PATCH] iw_cxgb4: use wildcard mapping for getting remote addr info Steve Wise
[not found] ` <20150507145224.28735.97977.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org>
2015-05-07 15:20 ` Doug Ledford
2015-05-07 15:43 ` Nikolova, Tatyana E
2015-05-07 20:23 ` Tatyana Nikolova
2015-05-07 20:45 ` Jason Gunthorpe
[not found] ` <20150507204508.GA1195-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-07 21:00 ` Steve Wise [this message]
[not found] ` <554BD282.7060800-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2015-05-07 21:09 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554BD282.7060800@opengridcomputing.com \
--to=swise-7bpotxp6k4+p2yhjcf5u+vpxobypeauw@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.