From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57027)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1YqUH7-0006fs-6P
	for qemu-devel@nongnu.org; Thu, 07 May 2015 18:28:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1YqUH2-0004Ve-5s
	for qemu-devel@nongnu.org; Thu, 07 May 2015 18:28:13 -0400
Received: from cantor2.suse.de ([195.135.220.15]:51029 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1YqUH2-0004VY-0P
	for qemu-devel@nongnu.org; Thu, 07 May 2015 18:28:08 -0400
Message-ID: <554BE6F6.8080807@suse.de>
Date: Fri, 08 May 2015 00:28:06 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1430819017-10877-1-git-send-email-kraxel@redhat.com>
	<1430819017-10877-4-git-send-email-kraxel@redhat.com>
In-Reply-To: <1430819017-10877-4-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL 3/6] console-gl: add opengl rendering helper
 functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org



On 05.05.15 11:43, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
> ---

[...]

> +void surface_gl_create_texture(ConsoleGLState *gls,
> +                               DisplaySurface *surface)
> +{
> +    assert(gls);
> +    assert(surface_stride(surface) % surface_bytes_per_pixel(surface) =
=3D=3D 0);
> +
> +    switch (surface->format) {
> +    case PIXMAN_BE_b8g8r8x8:
> +    case PIXMAN_BE_b8g8r8a8:
> +        surface->glformat =3D GL_BGRA_EXT;
> +        surface->gltype =3D GL_UNSIGNED_BYTE;
> +        break;
> +    case PIXMAN_r5g6b5:
> +        surface->glformat =3D GL_RGB;
> +        surface->gltype =3D GL_UNSIGNED_SHORT_5_6_5;
> +        break;
> +    default:
> +        g_assert_not_reached();
> +    }
> +
> +    glGenTextures(1, &surface->texture);
> +    glEnable(GL_TEXTURE_2D);
> +    glBindTexture(GL_TEXTURE_2D, surface->texture);
> +    glPixelStorei(GL_UNPACK_ROW_LENGTH_EXT,

This doesn't compile for me on SLES11:

ui/console-gl.c: In function =91surface_gl_create_texture=92:
ui/console-gl.c:97:19: error: =91GL_UNPACK_ROW_LENGTH_EXT=92 undeclared
(first use in this function)
ui/console-gl.c:97:19: note: each undeclared identifier is reported only
once for each function it appears in
ui/console-gl.c: In function =91surface_gl_update_texture=92:
ui/console-gl.c:117:19: error: =91GL_UNPACK_ROW_LENGTH_EXT=92 undeclared
(first use in this function)
make: *** [ui/console-gl.o] Error 1
make: *** Waiting for unfinished jobs....

Didn't we have buildbots to catch these things early?


Alex