All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kinglong Mee <kinglongmee@gmail.com>
To: Steve Dickson <SteveD@redhat.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
	Eino Juhani Oltedal <e.j.oltedal@fys.uio.no>,
	kinglongmee@gmail.com
Subject: Re: [PATCH 3/3] osd_login: add --disable-osdlogin for configure osd_login
Date: Fri, 08 May 2015 08:23:16 +0800	[thread overview]
Message-ID: <554C01F4.2060003@gmail.com> (raw)
In-Reply-To: <554B834A.5030405@RedHat.com>


On 5/7/2015 11:22 PM, Steve Dickson wrote:
> Hello,
> 
> On 05/07/2015 10:59 AM, Kinglong Mee wrote:
>> Miss updating of utils/Makefile.am in your tree.
>>
>> http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commitdiff;h=3e28fe73af023bf42e0d654146bfb9314b4d8438
> Are you saying something is missing??

Yes,
the old patch also update utils/Makefile.am, 
otherwise adding --enable-osdlogin is useless.


diff --git a/utils/Makefile.am b/utils/Makefile.am
index b892dc8..6dd4a57 100644
--- a/utils/Makefile.am
+++ b/utils/Makefile.am
@@ -25,6 +25,10 @@ if CONFIG_NFSDCLTRACK
 OPTDIRS += nfsdcltrack
 endif
 
+if CONFIG_OSD_LOGIN
+OPTDIRS += osd_login
+endif
+
 SUBDIRS = \
 	exportfs \
 	mountd \
@@ -32,7 +36,6 @@ SUBDIRS = \
 	nfsstat \
 	showmount \
 	statd \
-	osd_login \
 	$(OPTDIRS)
 
 MAINTAINERCLEANFILES = Makefile.in
-- 2.3.5 

      reply	other threads:[~2015-05-08  0:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-15 16:20 [PATCH 3/3] osd_login: add --disable-osdlogin for configure osd_login Kinglong Mee
2015-05-07 14:16 ` Steve Dickson
2015-05-07 14:59   ` Kinglong Mee
2015-05-07 15:22     ` Steve Dickson
2015-05-08  0:23       ` Kinglong Mee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554C01F4.2060003@gmail.com \
    --to=kinglongmee@gmail.com \
    --cc=SteveD@redhat.com \
    --cc=e.j.oltedal@fys.uio.no \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.