From: Guenter Roeck <linux@roeck-us.net>
To: Doug Anderson <dianders@chromium.org>, wim@iguana.be
Cc: jszhang@marvell.com, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] watchdog: dw_wdt: keepalive the watchdog at write time
Date: Thu, 07 May 2015 18:47:46 -0700 [thread overview]
Message-ID: <554C15C2.60802@roeck-us.net> (raw)
In-Reply-To: <1431036564-4189-2-git-send-email-dianders@chromium.org>
On 05/07/2015 03:09 PM, Doug Anderson wrote:
> If you've got code that does this in a tight loop
> 1. Open watchdog
> 2. Send 'expect close'
> 3. Close watchdog
> ...you'll eventually trigger a watchdog reset. You can reproduce this
> by using daisydog (1) and running:
> while true; do daisydog -c > /dev/null; done
>
> The problem is that each time you write to the watchdog for 'expect
> close' it moves the timer .5 seconds out. The timer thus never fires
> and never pats the watchdog for you.
>
> 1: http://git.chromium.org/gitweb/?p=chromiumos/third_party/daisydog.git
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
next prev parent reply other threads:[~2015-05-08 1:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 22:09 [PATCH 1/2] watchdog: dw_wdt: Use a mutex, not a spinlock Doug Anderson
2015-05-07 22:09 ` [PATCH 2/2] watchdog: dw_wdt: keepalive the watchdog at write time Doug Anderson
2015-05-08 1:47 ` Guenter Roeck [this message]
2015-05-08 2:41 ` Jisheng Zhang
2015-05-08 1:47 ` [PATCH 1/2] watchdog: dw_wdt: Use a mutex, not a spinlock Guenter Roeck
2015-05-08 4:01 ` Doug Anderson
2015-05-08 2:40 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554C15C2.60802@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dianders@chromium.org \
--cc=jszhang@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.