From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41487)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhaoshenglong@huawei.com>) id 1YqXya-0007JI-88
	for qemu-devel@nongnu.org; Thu, 07 May 2015 22:25:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhaoshenglong@huawei.com>) id 1YqXyX-0003qd-1p
	for qemu-devel@nongnu.org; Thu, 07 May 2015 22:25:20 -0400
Received: from szxga01-in.huawei.com ([58.251.152.64]:50572)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhaoshenglong@huawei.com>) id 1YqXyW-0003pc-8a
	for qemu-devel@nongnu.org; Thu, 07 May 2015 22:25:16 -0400
Message-ID: <554C1E6B.8070701@huawei.com>
Date: Fri, 8 May 2015 10:24:43 +0800
From: Shannon Zhao <zhaoshenglong@huawei.com>
MIME-Version: 1.0
References: <1430990964-10528-1-git-send-email-zhaoshenglong@huawei.com>
	<1430990964-10528-6-git-send-email-zhaoshenglong@huawei.com>
	<CAFEAcA_RpG69nQghzcnqa7pMDMJQ5t=dTzys9nab+nzv_0aWmg@mail.gmail.com>
In-Reply-To: <CAFEAcA_RpG69nQghzcnqa7pMDMJQ5t=dTzys9nab+nzv_0aWmg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v6 05/22] hw/acpi/aml-build: Add
	aml_interrupt() term
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: hangaohuai@huawei.com, "Michael S. Tsirkin" <mst@redhat.com>, Alexander Spyridakis <a.spyridakis@virtualopensystems.com>, Claudio Fontana <claudio.fontana@huawei.com>, QEMU Developers <qemu-devel@nongnu.org>, "Huangpeng (Peter)" <peter.huangpeng@huawei.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, Hanjun Guo <hanjun.guo@linaro.org>, Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Laszlo Ersek <lersek@redhat.com>, Christoffer Dall <christoffer.dall@linaro.org>, Shannon Zhao <shannon.zhao@linaro.org>

On 2015/5/7 23:51, Peter Maydell wrote:
> On 7 May 2015 at 10:29, Shannon Zhao <zhaoshenglong@huawei.com> wrote:
>> > From: Shannon Zhao <shannon.zhao@linaro.org>
>> >
>> > Add aml_interrupt() for describing device interrupt in resource template.
>> > These can be used to generating DSDT table for ACPI on ARM.
>> > +    /* Interrupt Number */
>> > +    build_append_byte(var->buf, extract32(irq, 0, 8)); /* bits[7:0] */
>> > +    build_append_byte(var->buf, extract32(irq, 8, 8)); /* bits[15:8] */
>> > +    build_append_byte(var->buf, extract32(irq, 16, 8)); /* bits[23:16] */
>> > +    build_append_byte(var->buf, extract32(irq, 24, 8)); /* bits[31:24] */
> You used this twice in the previous patch and again here. Can
> we factor it out so we can
>   build_append_uint32(var->buf, irq);
> 

Ok, thanks for your suggestion, will fix this.

-- 
Shannon