Re: [PATCH] unswap the grave and 102nd keys on Apple Alu ISO keyboard

["Michel Dänzer" <michel@daenzer.net>]

On 04.05.2015 17:11, Jiri Kosina wrote:
> On Mon, 4 May 2015, Jiri Kosina wrote:
> 
>> On Mon, 4 May 2015, Jiri Kosina wrote:
>>
>>> On Fri, 1 May 2015, John Horan wrote:
>>>
>>>> The quirk for swapping the grave and 102nd keys should be applied to the 
>>>> APPLE_ALU_ISO keyboard, as they aren't actually swapped.
>>>>
>>>> Signed-off-by: John Horan <knasher@gmail.com>
>>>> ---
>>>>  drivers/hid/hid-apple.c | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
>>>> index f822fd2..e4bbfc0 100644
>>>> --- a/drivers/hid/hid-apple.c
>>>> +++ b/drivers/hid/hid-apple.c
>>>> @@ -441,7 +441,7 @@ static const struct hid_device_id apple_devices[] = {
>>>>  	{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_ANSI),
>>>>  		.driver_data = APPLE_HAS_FN },
>>>>  	{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_ISO),
>>>> -		.driver_data = APPLE_HAS_FN | APPLE_ISO_KEYBOARD },
>>>> +		.driver_data = APPLE_HAS_FN },
>>>>  	{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_JIS),
>>>>  		.driver_data = APPLE_HAS_FN },
>>>>  	{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_GEYSER4_HF_ANSI),
>>>
>>> Okay, this has been there since 2007, so one would guess there must be a 
>>> reason for noone complaining about this for past 8 years. I'd rather be 
>>> careful here so that we don't introduce any regressions.
>>>
>>> Adding Michel, who added the original quirk back in 2007 (through commit 
>>> a45d82d19a6 ("HID: Add support for Apple aluminum USB keyboards")) to CC.

With my ISO Apple Aluminum keyboard:

Bus 006 Device 021: ID 05ac:0221 Apple, Inc. Aluminum Keyboard (ISO)

writing 0 to /sys/module/hid_apple/parameters/iso_layout (which disables
the APPLE_ISO_KEYBOARD quirk) results in the key right of the left shift
key (labelled "`" and "~") producing the wrong characters. With the
quirk enabled, it produces "`" and "~" as expected.


John, please provide more information about the problem you're trying to
solve with this patch.


>> Okay, the original e-mail address of Michel bounces, let's try a different 
>> one :)
> 
> Hmm, that bounced again. One last attempt ...

Third time's the charm. :)


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html