From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH Remus v1 5/8] tools/libxc: defer the setting
 of HVM_PARAM_IDENT_PT
Date: Fri, 8 May 2015 09:19:20 +0100
Message-ID: <554C7188.5050507@citrix.com>
References: <1430980646-316-1-git-send-email-yanghy@cn.fujitsu.com>
	<1430980646-316-6-git-send-email-yanghy@cn.fujitsu.com>
	<554B3FE5.2060300@citrix.com> <554B6FCD.3030804@cn.fujitsu.com>
	<554B83A8.9060605@citrix.com> <554C4064.60700@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <554C4064.60700@cn.fujitsu.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Hongyang Yang <yanghy@cn.fujitsu.com>, xen-devel@lists.xen.org
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, wency@cn.fujitsu.com, eddie.dong@intel.com, yunhong.jiang@intel.com, ian.jackson@eu.citrix.com, rshriram@cs.ubc.ca
List-Id: xen-devel@lists.xenproject.org

On 08/05/15 05:49, Hongyang Yang wrote:
> Hi Andrew,
>
> On 05/07/2015 11:24 PM, Andrew Cooper wrote:
>> On 07/05/15 14:59, Hongyang Yang wrote:
>>>
>>>
>>> On 05/07/2015 06:35 PM, Andrew Cooper wrote:
>>>> On 07/05/15 07:37, Yang Hongyang wrote:
>>>>> Set the hvm param HVM_PARAM_IDENT_PT second time will fail.
>>>>> So defer the setting of HVM_PARAM_IDENT_PT.
>>>>>
>>>>> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
>>>>
>>>> I would argue that this is a Xen bug, not a migration bug.  There is
>>>> nothing conceptually wrong with setting this param multiple times.
>>>
>>> I noticed that in legacy migration, this was set multiple times, so
>>> this patch is only a workaround that will avoid the fail in my test.
>>> will try your hypervisor patch tomorrow.
>>
>> Try this version, which has been rebased over Pauls' cleanup in this
>> area which has just been committed to staging.
>
> A quick test show that this patch fix the problem, will you send this
> patch separately or I put this patch into my series?

I am putting together a short series to help your integration.  I shall
include this with a proper commit message etc.

~Andrew