From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH] drm/rockchip: Add BGR formats to VOP Date: Fri, 08 May 2015 17:31:14 +0800 Message-ID: <554C8262.3090605@rock-chips.com> References: <1431072968-12696-1-git-send-email-tfiga@chromium.org> <554C766A.8070103@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomasz Figa Cc: "linux-kernel@vger.kernel.org" , "open list:ARM/Rockchip SoC..." , dri-devel@lists.freedesktop.org, "linux-arm-kernel@lists.infradead.org" List-Id: linux-rockchip.vger.kernel.org T24gMjAxNeW5tDA15pyIMDjml6UgMTY6NDksIFRvbWFzeiBGaWdhIHdyb3RlOgo+IEhpIE1hcmss Cj4KPiBUaGFua3MgZm9yIHJldmlldy4KPgo+IE9uIEZyaSwgTWF5IDgsIDIwMTUgYXQgNTo0MCBQ TSwgTWFyayB5YW8gPG1hcmsueWFvQHJvY2stY2hpcHMuY29tPiB3cm90ZToKPj4+IEBAIC0yMzMs NiArMjQzLDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCB2b3Bfd2luX3BoeSB3aW4yM19kYXRhID0g ewo+Pj4gICAgICAgICAgLm5mb3JtYXRzID0gQVJSQVlfU0laRShmb3JtYXRzXzIzNCksCj4+PiAg ICAgICAgICAuZW5hYmxlID0gVk9QX1JFRyhXSU4yX0NUUkwwLCAweDEsIDApLAo+Pj4gICAgICAg ICAgLmZvcm1hdCA9IFZPUF9SRUcoV0lOMl9DVFJMMCwgMHg3LCAxKSwKPj4+ICsgICAgICAgLnJi X3N3YXAgPSBWT1BfUkVHKFdJTjBfQ1RSTDAsIDB4MSwgMTIpLAo+PiBTaG91bGQgYmU6Cj4+Cj4+ ICAgICAgICAgIC5yYl9zd2FwID0gVk9QX1JFRyhWT1BfV0lOMl9DVFJMMCwgMHgxLCAxMiksCj4+ Cj4gUmlnaHQsIGdvb2QgY2F0Y2guCj4KPj4+ICAgICAgICAgIC5kc3BfaW5mbyA9IFZPUF9SRUco V0lOMl9EU1BfSU5GTzAsIDB4MGZmZjBmZmYsIDApLAo+Pj4gICAgICAgICAgLmRzcF9zdCA9IFZP UF9SRUcoV0lOMl9EU1BfU1QwLCAweDFmZmYxZmZmLCAwKSwKPj4+ICAgICAgICAgIC55cmdiX21z dCA9IFZPUF9SRUcoV0lOMl9NU1QwLCAweGZmZmZmZmZmLCAwKSwKPj4+IEBAIC0yNDYsNiArMjU3 LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCB2b3Bfd2luX3BoeSBjdXJzb3JfZGF0YSA9IHsKPj4+ ICAgICAgICAgIC5uZm9ybWF0cyA9IEFSUkFZX1NJWkUoZm9ybWF0c18yMzQpLAo+Pj4gICAgICAg ICAgLmVuYWJsZSA9IFZPUF9SRUcoSFdDX0NUUkwwLCAweDEsIDApLAo+Pj4gICAgICAgICAgLmZv cm1hdCA9IFZPUF9SRUcoSFdDX0NUUkwwLCAweDcsIDEpLAo+Pj4gKyAgICAgICAucmJfc3dhcCA9 IFZPUF9SRUcoV0lOMF9DVFJMMCwgMHgxLCAxMiksCj4+IGN1cnNvciB3aW4gbm90IHN1cHBvcnQg cmJfc3dhcCwgcmVtb3ZlIGl0Lgo+Pgo+IEhtbSwgYWNjb3JkaW5nIHRvIHRoZSBkYXRhc2hlZXQg b2YgUkszMjg4IEkgaGF2ZSAoMC43LCBPY3RvYmVyIDIwMTQpLAo+IHRoZXJlIGlzIGEgZmllbGQg Y2FsbGVkIGh3Y19yYl9zd2FwIGF0IGJpdCAxMiBvZiBIV0NfQ1RSTDAgcmVnaXN0ZXIuCj4gSXMg aXQgYW4gZXJyb3IgaW4gdGhlIGRhdGFzaGVldD8KPgo+IEJlc3QgcmVnYXJkcywKPiBUb21hc3oK Pgo+Cj4KT2gsIHllcywgSSBmaW5kIGl0LCByYl9zd2FwIGF0IEhXQ19DVFJMMCBiaXQgMTIuIHlv dSBhcmUgcmlnaHQuClRoYW5rcyA6LSkKCi0tIArvvK1hcmsgWWFvCgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Fri, 08 May 2015 17:31:14 +0800 Subject: [PATCH] drm/rockchip: Add BGR formats to VOP In-Reply-To: References: <1431072968-12696-1-git-send-email-tfiga@chromium.org> <554C766A.8070103@rock-chips.com> Message-ID: <554C8262.3090605@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015?05?08? 16:49, Tomasz Figa wrote: > Hi Mark, > > Thanks for review. > > On Fri, May 8, 2015 at 5:40 PM, Mark yao wrote: >>> @@ -233,6 +243,7 @@ static const struct vop_win_phy win23_data = { >>> .nformats = ARRAY_SIZE(formats_234), >>> .enable = VOP_REG(WIN2_CTRL0, 0x1, 0), >>> .format = VOP_REG(WIN2_CTRL0, 0x7, 1), >>> + .rb_swap = VOP_REG(WIN0_CTRL0, 0x1, 12), >> Should be: >> >> .rb_swap = VOP_REG(VOP_WIN2_CTRL0, 0x1, 12), >> > Right, good catch. > >>> .dsp_info = VOP_REG(WIN2_DSP_INFO0, 0x0fff0fff, 0), >>> .dsp_st = VOP_REG(WIN2_DSP_ST0, 0x1fff1fff, 0), >>> .yrgb_mst = VOP_REG(WIN2_MST0, 0xffffffff, 0), >>> @@ -246,6 +257,7 @@ static const struct vop_win_phy cursor_data = { >>> .nformats = ARRAY_SIZE(formats_234), >>> .enable = VOP_REG(HWC_CTRL0, 0x1, 0), >>> .format = VOP_REG(HWC_CTRL0, 0x7, 1), >>> + .rb_swap = VOP_REG(WIN0_CTRL0, 0x1, 12), >> cursor win not support rb_swap, remove it. >> > Hmm, according to the datasheet of RK3288 I have (0.7, October 2014), > there is a field called hwc_rb_swap at bit 12 of HWC_CTRL0 register. > Is it an error in the datasheet? > > Best regards, > Tomasz > > > Oh, yes, I find it, rb_swap at HWC_CTRL0 bit 12. you are right. Thanks :-) -- ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752660AbbEHJbf (ORCPT ); Fri, 8 May 2015 05:31:35 -0400 Received: from regular1.263xmail.com ([211.150.99.135]:53960 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750907AbbEHJbc (ORCPT ); Fri, 8 May 2015 05:31:32 -0400 X-Greylist: delayed 3069 seconds by postgrey-1.27 at vger.kernel.org; Fri, 08 May 2015 05:31:31 EDT X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: tfiga@chromium.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <28bf27101f461886f726be56243895ed> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <554C8262.3090605@rock-chips.com> Date: Fri, 08 May 2015 17:31:14 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Tomasz Figa CC: dri-devel@lists.freedesktop.org, "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "linux-kernel@vger.kernel.org" , Daniel Kurtz , Heiko Stuebner , David Airlie Subject: Re: [PATCH] drm/rockchip: Add BGR formats to VOP References: <1431072968-12696-1-git-send-email-tfiga@chromium.org> <554C766A.8070103@rock-chips.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年05月08日 16:49, Tomasz Figa wrote: > Hi Mark, > > Thanks for review. > > On Fri, May 8, 2015 at 5:40 PM, Mark yao wrote: >>> @@ -233,6 +243,7 @@ static const struct vop_win_phy win23_data = { >>> .nformats = ARRAY_SIZE(formats_234), >>> .enable = VOP_REG(WIN2_CTRL0, 0x1, 0), >>> .format = VOP_REG(WIN2_CTRL0, 0x7, 1), >>> + .rb_swap = VOP_REG(WIN0_CTRL0, 0x1, 12), >> Should be: >> >> .rb_swap = VOP_REG(VOP_WIN2_CTRL0, 0x1, 12), >> > Right, good catch. > >>> .dsp_info = VOP_REG(WIN2_DSP_INFO0, 0x0fff0fff, 0), >>> .dsp_st = VOP_REG(WIN2_DSP_ST0, 0x1fff1fff, 0), >>> .yrgb_mst = VOP_REG(WIN2_MST0, 0xffffffff, 0), >>> @@ -246,6 +257,7 @@ static const struct vop_win_phy cursor_data = { >>> .nformats = ARRAY_SIZE(formats_234), >>> .enable = VOP_REG(HWC_CTRL0, 0x1, 0), >>> .format = VOP_REG(HWC_CTRL0, 0x7, 1), >>> + .rb_swap = VOP_REG(WIN0_CTRL0, 0x1, 12), >> cursor win not support rb_swap, remove it. >> > Hmm, according to the datasheet of RK3288 I have (0.7, October 2014), > there is a field called hwc_rb_swap at bit 12 of HWC_CTRL0 register. > Is it an error in the datasheet? > > Best regards, > Tomasz > > > Oh, yes, I find it, rb_swap at HWC_CTRL0 bit 12. you are right. Thanks :-) -- Ｍark Yao