From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?windows-1252?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH] xen/pvh: trap access to IO port range
	0xcf8-0xcfb
Date: Fri, 8 May 2015 12:22:33 +0200
Message-ID: <554C8E69.6070002@citrix.com>
References: <1431079231-24272-1-git-send-email-roger.pau@citrix.com>
	<554CA9880200007800078249@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <roger.pau@citrix.com>) id 1YqfQV-00057M-Hu
	for xen-devel@lists.xenproject.org; Fri, 08 May 2015 10:22:39 +0000
In-Reply-To: <554CA9880200007800078249@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

El 08/05/15 a les 12.18, Jan Beulich ha escrit:
>>>> On 08.05.15 at 12:00, <roger.pau@citrix.com> wrote:
>> --- a/xen/arch/x86/setup.c
>> +++ b/xen/arch/x86/setup.c
>> @@ -1527,7 +1527,7 @@ static int __hwdom_init io_bitmap_cb(unsigned long s, 
>> unsigned long e,
>>  
>>  void __hwdom_init setup_io_bitmap(struct domain *d)
>>  {
>> -    int rc;
>> +    int rc, i;
> 
> The new variable ought to be of unsigned type and could go
> into the more narrow scope it's needed in.

Why of type unsigned? __set_bit expects an int.

>> @@ -1535,6 +1535,12 @@ void __hwdom_init setup_io_bitmap(struct domain *d)
>>          rc = rangeset_report_ranges(d->arch.ioport_caps, 0, 0x10000,
>>                                      io_bitmap_cb, d);
>>          BUG_ON(rc);
>> +        /*
>> +         * NB: we need to trap accesses to the range 0xcf8-0xcfb in order
>> +         * to intercept 4 byte accesses.
>> +         */
>> +        for ( i = 0xcf8; i < 0xcfc; i++ )
>> +            __set_bit(i, d->arch.hvm_domain.io_bitmap);
> 
> To achieve what the comment says you'd really only need to
> set any one of the four bits.

Indeed, but I think it's more clear this way, the effect is exactly the
same. If you prefer I can only set 0xcf8 and we can get rid of the extra
i variable.

Roger.