Re: [PATCH v2 00/19] xen: arm: cleanup traps.c

[Julien Grall <julien.grall@citrix.com>]

Hi Ian,

On 17/04/15 15:01, Ian Campbell wrote:
> (R)eviewed
> 
> R	xen: arm: constify union hsr and struct hsr_* where possible.
> R	xen: arm: Fix handling of ICC_{SGI1R,SGI0R,ASGI1R}_EL1
> R	xen: arm: call inject_undef_exception directly
>  M	xen: arm: provide and use a handle_raz_wi helper
>  M	xen: arm: Add and use r/o+raz and w/o+wi helpers
>  M	xen: arm: add minimum exception level argument to trap handler helpers
>  M	xen: arm: Annotate trap handler for HSR_EL2.{TWI,TWE,TSC}
>  M	xen: arm: implement handling of ACTLR_EL1 trap
> RM	xen: arm: Annotate registers trapped by HCR_EL1.TIDCP
>  M	xen: arm: implement handling of registers trapped by CPTR_EL2.TTA
>  M	xen: arm: Annotate handlers for CPTR_EL2.Tx
>  M	xen: arm: Annotate the handlers for HSTR_EL2.T15
>  M	xen: arm: Annotate registers trapped by MDCR_EL2.TDRA
>  M	xen: arm: Annotate registers trapped by MDCR_EL2.TDOSA
> 	xen: arm: Annotate registers trapped by MDCR_EL2.TDA
> 	xen: arm: Annotate registers trapped by MDCR_EL2.TPM and TPMCR
> R	xen: arm: Remove CNTPCT_EL0 trap handling.
> 	xen: arm: Annotate registers trapped when CNTHCTL_EL2.EL1PCEN == 0
> R	xen: arm: Annotate source of ICC SGI register trapping

I added my Reviewed-by to all the patch except #16.

Although it was only a NIT in the subject. If you don't want to bother
resending the whole series on the ML for few NITs, you can add my
Reviewed-by to this patch too.

Regards,

-- 
Julien Grall