From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Verkuil Subject: Re: [PATCH v6 06/11] cec: add HDMI CEC framework Date: Fri, 08 May 2015 13:30:13 +0200 Message-ID: <554C9E45.7090800@xs4all.nl> References: <1430760785-1169-1-git-send-email-k.debski@samsung.com> <1430760785-1169-7-git-send-email-k.debski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1430760785-1169-7-git-send-email-k.debski@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kamil Debski , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org, sean@mess.org, mchehab@osg.samsung.com, dmitry.torokhov@gmail.com, lars@opdenkamp.eu, Hans Verkuil , kyungmin.park@samsung.com, thomas@tommie-lie.de, linux-input@vger.kernel.org, m.szyprowski@samsung.com List-Id: linux-input@vger.kernel.org SGkgS2FtaWwsCgpKdXN0IHR3byB0aW55IGlzc3VlcywgYW5kIGFmdGVyIHRoYXQgeW91IGNhbiBh ZGQgbXk6CgpSZXZpZXdlZC1ieTogSGFucyBWZXJrdWlsIDxoYW5zLnZlcmt1aWxAY2lzby5jb20+ Cgp0byB0aGlzLgoKT24gMDUvMDQvMjAxNSAwNzozMiBQTSwgS2FtaWwgRGVic2tpIHdyb3RlOgo+ IGRpZmYgLS1naXQgYS9pbmNsdWRlL3VhcGkvbGludXgvY2VjLmggYi9pbmNsdWRlL3VhcGkvbGlu dXgvY2VjLmgKPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+IGluZGV4IDAwMDAwMDAuLjY3YjAwNDkK PiAtLS0gL2Rldi9udWxsCj4gKysrIGIvaW5jbHVkZS91YXBpL2xpbnV4L2NlYy5oCj4gQEAgLTAs MCArMSwzMzIgQEAKPiArI2lmbmRlZiBfQ0VDX0gKPiArI2RlZmluZSBfQ0VDX0gKPiArCj4gKyNp bmNsdWRlIDxsaW51eC90eXBlcy5oPgo+ICsKPiArc3RydWN0IGNlY19tc2cgewo+ICsJX191NjQg dHM7Cj4gKwlfX3UzMiBsZW47Cj4gKwlfX3UzMiBzdGF0dXM7Cj4gKwlfX3UzMiB0aW1lb3V0Owo+ ICsJLyogdGltZW91dCAoaW4gbXMpIGlzIHVzZWQgdG8gdGltZW91dCBDRUNfUkVDRUlWRS4KPiAr CSAgIFNldCB0byAwIGlmIHlvdSB3YW50IHRvIHdhaXQgZm9yZXZlci4gKi8KPiArCV9fdTggIG1z Z1sxNl07Cj4gKwlfX3U4ICByZXBseTsKPiArCS8qIElmIG5vbi16ZXJvLCB0aGVuIHdhaXQgZm9y IGEgcmVwbHkgd2l0aCB0aGlzIG9wY29kZS4KPiArCSAgIElmIHRoZXJlIHdhcyBhbiBlcnJvciB3 aGVuIHNlbmRpbmcgdGhlIG1zZyBvciBGZWF0dXJlQWJvcnQKPiArCSAgIHdhcyByZXR1cm5lZCwg dGhlbiByZXBseSBpcyBzZXQgdG8gMC4KPiArCSAgIElmIHJlcGx5IGlzIG5vbi16ZXJvIHVwb24g cmV0dXJuLCB0aGVuIGxlbi9tc2cgYXJlIHNldCB0bwo+ICsJICAgdGhlIHJlY2VpdmVkIG1lc3Nh Z2UuCj4gKwkgICBJZiByZXBseSBpcyB6ZXJvIHVwb24gcmV0dXJuIGFuZCBzdGF0dXMgaGFzIHRo ZQo+ICsJICAgQ0VDX1RYX1NUQVRVU19GRUFUVVJFX0FCT1JUIGJpdCBzZXQsIHRoZW4gbGVuL21z ZyBhcmUgc2V0IHRvIHRoZQo+ICsJICAgcmVjZWl2ZWQgZmVhdHVyZSBhYm9ydCBtZXNzYWdlLgo+ ICsJICAgSWYgcmVwbHkgaXMgemVybyB1cG9uIHJldHVybiBhbmQgc3RhdHVzIGhhcyB0aGUKPiAr CSAgIENFQ19UWF9TVEFUVVNfUkVQTFlfVElNRU9VVAo+ICsJICAgYml0IHNldCwgdGhlbiBubyBy ZXBseSB3YXMgc2VlbiBhdCBhbGwuCj4gKwkgICBUaGlzIGZpZWxkIGlzIGlnbm9yZWQgd2l0aCBD RUNfUkVDRUlWRS4KPiArCSAgIElmIHJlcGx5IGlzIG5vbi16ZXJvIGZvciBDRUNfVFJBTlNNSVQg YW5kIHRoZSBtZXNzYWdlIGlzIGEgYnJvYWRjYXN0LAo+ICsJICAgdGhlbiAtRUlOVkFMIGlzIHJl dHVybmVkLgo+ICsJICAgaWYgcmVwbHkgaXMgbm9uLXplcm8sIHRoZW4gdGltZW91dCBpcyBzZXQg dG8gMTAwMCAodGhlIHJlcXVpcmVkCj4gKwkgICBtYXhpbXVtIHJlc3BvbnNlIHRpbWUpLgo+ICsJ ICovCj4gKwlfX3UzMiBzZXF1ZW5jZTsKPiArCS8qIFRoZSBmcmFtZXdvcmsgYXNzaWducyBhIHNl cXVlbmNlIG51bWJlciB0byBtZXNzYWdlcyB0aGF0IGFyZSBzZW50Lgo+ICsJICogVGhpcyBjYW4g YmUgdXNlZCB0byB0cmFjayByZXBsaWVzIHRvIHByZXZpb3VzbHkgc2VudCBtZXNzYWdlcy4KPiAr CSAqLwo+ICsJX191OCByZXNlcnZlZFszNV07Cj4gK307CgpJdCBpcyBjb25mdXNpbmcgaW4gc3Ry dWN0IGNlY19tc2cgdGhhdCB0aGUgY29tbWVudHMgY29tZSAqYWZ0ZXIqIHRoZSBmaWVsZAp0aGV5 IGJlbG9uZyB0byBpbnN0ZWFkIG9mIGp1c3QgYmVmb3JlLiBDYW4geW91IGNoYW5nZSB0aGlzPwoK PiArCj4gKyNkZWZpbmUgQ0VDX0dfRVZFTlQJCV9JT1dSKCdhJywgOSwgc3RydWN0IGNlY19ldmVu dCkKClRoaXMgY2FuIGJlIF9fSU9SIHNpbmNlIHdlIG5ldmVyIHdyaXRlIGFueXRoaW5nLgoKPiAr LyoKPiArICAgUmVhZCBhbmQgc2V0IHRoZSB2ZW5kb3IgSUQgb2YgdGhlIENFQyBhZGFwdGVyLgo+ ICsgKi8KPiArI2RlZmluZSBDRUNfR19WRU5ET1JfSUQJCV9JT1IoJ2EnLCAxMCwgX191MzIpCj4g KyNkZWZpbmUgQ0VDX1NfVkVORE9SX0lECQlfSU9XKCdhJywgMTEsIF9fdTMyKQo+ICsvKgo+ICsg ICBFbmFibGUvZGlzYWJsZSB0aGUgcGFzc3Rocm91Z2ggbW9kZQo+ICsgKi8KPiArI2RlZmluZSBD RUNfR19QQVNTVEhST1VHSAlfSU9SKCdhJywgMTIsIF9fdTMyKQo+ICsjZGVmaW5lIENFQ19TX1BB U1NUSFJPVUdICV9JT1coJ2EnLCAxMywgX191MzIpCj4gKwo+ICsjZW5kaWYKPiAKClJlZ2FyZHMs CgoJSGFucwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb1-smtp-cloud2.xs4all.net ([194.109.24.21]:57696 "EHLO lb1-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753455AbbEHLab (ORCPT ); Fri, 8 May 2015 07:30:31 -0400 Message-ID: <554C9E45.7090800@xs4all.nl> Date: Fri, 08 May 2015 13:30:13 +0200 From: Hans Verkuil MIME-Version: 1.0 To: Kamil Debski , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org CC: m.szyprowski@samsung.com, mchehab@osg.samsung.com, kyungmin.park@samsung.com, thomas@tommie-lie.de, sean@mess.org, dmitry.torokhov@gmail.com, linux-input@vger.kernel.org, linux-samsung-soc@vger.kernel.org, lars@opdenkamp.eu, Hans Verkuil Subject: Re: [PATCH v6 06/11] cec: add HDMI CEC framework References: <1430760785-1169-1-git-send-email-k.debski@samsung.com> <1430760785-1169-7-git-send-email-k.debski@samsung.com> In-Reply-To: <1430760785-1169-7-git-send-email-k.debski@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Kamil, Just two tiny issues, and after that you can add my: Reviewed-by: Hans Verkuil to this. On 05/04/2015 07:32 PM, Kamil Debski wrote: > diff --git a/include/uapi/linux/cec.h b/include/uapi/linux/cec.h > new file mode 100644 > index 0000000..67b0049 > --- /dev/null > +++ b/include/uapi/linux/cec.h > @@ -0,0 +1,332 @@ > +#ifndef _CEC_H > +#define _CEC_H > + > +#include > + > +struct cec_msg { > + __u64 ts; > + __u32 len; > + __u32 status; > + __u32 timeout; > + /* timeout (in ms) is used to timeout CEC_RECEIVE. > + Set to 0 if you want to wait forever. */ > + __u8 msg[16]; > + __u8 reply; > + /* If non-zero, then wait for a reply with this opcode. > + If there was an error when sending the msg or FeatureAbort > + was returned, then reply is set to 0. > + If reply is non-zero upon return, then len/msg are set to > + the received message. > + If reply is zero upon return and status has the > + CEC_TX_STATUS_FEATURE_ABORT bit set, then len/msg are set to the > + received feature abort message. > + If reply is zero upon return and status has the > + CEC_TX_STATUS_REPLY_TIMEOUT > + bit set, then no reply was seen at all. > + This field is ignored with CEC_RECEIVE. > + If reply is non-zero for CEC_TRANSMIT and the message is a broadcast, > + then -EINVAL is returned. > + if reply is non-zero, then timeout is set to 1000 (the required > + maximum response time). > + */ > + __u32 sequence; > + /* The framework assigns a sequence number to messages that are sent. > + * This can be used to track replies to previously sent messages. > + */ > + __u8 reserved[35]; > +}; It is confusing in struct cec_msg that the comments come *after* the field they belong to instead of just before. Can you change this? > + > +#define CEC_G_EVENT _IOWR('a', 9, struct cec_event) This can be __IOR since we never write anything. > +/* > + Read and set the vendor ID of the CEC adapter. > + */ > +#define CEC_G_VENDOR_ID _IOR('a', 10, __u32) > +#define CEC_S_VENDOR_ID _IOW('a', 11, __u32) > +/* > + Enable/disable the passthrough mode > + */ > +#define CEC_G_PASSTHROUGH _IOR('a', 12, __u32) > +#define CEC_S_PASSTHROUGH _IOW('a', 13, __u32) > + > +#endif > Regards, Hans