All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] x86: don't clear high 32 bits of RAX on sub-word guest I/O port reads
Date: Fri, 8 May 2015 13:36:51 +0100	[thread overview]
Message-ID: <554CADE3.2020601@citrix.com> (raw)
In-Reply-To: <554CC34502000078000783A3@mail.emea.novell.com>

On 08/05/15 13:08, Jan Beulich wrote:
> 1- or 2-byte operations never alter the high halves of registers.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
> --- a/xen/arch/x86/traps.c
> +++ b/xen/arch/x86/traps.c
> @@ -2234,7 +2234,7 @@ static int emulate_privileged_op(struct 
>              if ( op_bytes == 4 )
>                  regs->eax = 0;
>              else
> -                regs->eax &= ~((1u << (op_bytes * 8)) - 1);
> +                regs->eax &= ~((1 << (op_bytes * 8)) - 1);
>              regs->eax |= guest_io_read(port, op_bytes, v, regs);
>          }
>          bpmatch = check_guest_io_breakpoint(v, port, op_bytes);
>
>
>

  reply	other threads:[~2015-05-08 12:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08 12:08 [PATCH] x86: don't clear high 32 bits of RAX on sub-word guest I/O port reads Jan Beulich
2015-05-08 12:36 ` Andrew Cooper [this message]
2015-05-11 15:15 ` Konrad Rzeszutek Wilk
2015-05-12  9:27   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554CADE3.2020601@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=keir@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.