All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Emelyanov <xemul@parallels.com>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: Linux MM <linux-mm@kvack.org>
Subject: [PATCH] UserfaultFD: Fix stack corruption when zeroing uffd_msg
Date: Fri, 8 May 2015 17:07:27 +0300	[thread overview]
Message-ID: <554CC31F.9050509@parallels.com> (raw)
In-Reply-To: <554CBC99.2050808@parallels.com>


Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

---

diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c
index 026ef99..c89e96f 100644
--- a/fs/userfaultfd.c
+++ b/fs/userfaultfd.c
@@ -134,7 +134,7 @@ static inline void msg_init(struct uffd_msg *msg)
 	 * Must use memset to zero out the paddings or kernel data is
 	 * leaked to userland.
 	 */
-	memset(&msg, 0, sizeof(struct uffd_msg));
+	memset(msg, 0, sizeof(struct uffd_msg));
 }
 
 static inline struct uffd_msg userfault_msg(unsigned long address,


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2015-05-08 14:14 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-18 19:34 [PATCH 0/3] UserfaultFD: Extension for non cooperative uffd usage Pavel Emelyanov
2015-03-18 19:34 ` Pavel Emelyanov
2015-03-18 19:34 ` Pavel Emelyanov
     [not found] ` <5509D342.7000403-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2015-03-18 19:34   ` [PATCH 1/3] uffd: Tossing bits around Pavel Emelyanov
2015-03-18 19:34     ` Pavel Emelyanov
2015-03-18 19:34     ` Pavel Emelyanov
2015-03-18 19:35   ` [PATCH 2/3] uffd: Introduce the v2 API Pavel Emelyanov
2015-03-18 19:35     ` Pavel Emelyanov
2015-03-18 19:35     ` Pavel Emelyanov
     [not found]     ` <5509D375.7000809-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2015-04-21 12:18       ` Andrea Arcangeli
2015-04-21 12:18         ` Andrea Arcangeli
2015-04-21 12:18         ` Andrea Arcangeli
2015-04-23  6:29         ` Pavel Emelyanov
2015-04-23  6:29           ` Pavel Emelyanov
     [not found]           ` <55389133.8070701-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2015-04-27 21:12             ` Andrea Arcangeli
2015-04-27 21:12               ` Andrea Arcangeli
2015-04-27 21:12               ` Andrea Arcangeli
2015-04-30  9:50               ` Pavel Emelyanov
2015-04-30  9:50                 ` Pavel Emelyanov
2015-03-18 19:35   ` [PATCH 3/3] uffd: Introduce fork() notification Pavel Emelyanov
2015-03-18 19:35     ` Pavel Emelyanov
2015-03-18 19:35     ` Pavel Emelyanov
2015-04-21 12:02   ` [PATCH 0/3] UserfaultFD: Extension for non cooperative uffd usage Andrea Arcangeli
2015-04-21 12:02     ` Andrea Arcangeli
2015-04-21 12:02     ` Andrea Arcangeli
     [not found]     ` <20150421120222.GC4481-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-04-23  6:34       ` Pavel Emelyanov
2015-04-23  6:34         ` Pavel Emelyanov
2015-04-23  6:34         ` Pavel Emelyanov
     [not found]         ` <20150427211650.GC24035@redhat.com>
2015-04-30 16:38           ` [PATCH] UserfaultFD: Rename uffd_api.bits into .features Pavel Emelyanov
2015-05-07 13:42             ` Andrea Arcangeli
2015-05-07 14:28               ` Pavel Emelyanov
2015-05-07 14:33                 ` Andrea Arcangeli
2015-05-07 14:42                   ` Pavel Emelyanov
2015-05-07 15:11                     ` Andrea Arcangeli
2015-05-07 15:20                       ` Pavel Emelyanov
2015-05-07 17:08                         ` Andrea Arcangeli
2015-05-07 18:35                           ` Pavel Emelyanov
2015-05-08 13:39                           ` Pavel Emelyanov
2015-05-08 14:07                             ` Pavel Emelyanov [this message]
2015-05-08 17:54                               ` [PATCH] UserfaultFD: Fix stack corruption when zeroing uffd_msg Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554CC31F.9050509@parallels.com \
    --to=xemul@parallels.com \
    --cc=aarcange@redhat.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.