Re: [Qemu-devel] [PATCH 1/4] migration: move ram stuff to migration/ram

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1893 bytes --]

On 05/08/2015 06:43 AM, Juan Quintela wrote:
> For historic reasons, ram migration have been on arch_init.c.  Just

s/have been on/has been in/

> split it into migration/ram.c, the same that happened with block.c.
> 
> There is only code movement, no changes altogether.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  MAINTAINERS                   |    1 -
>  Makefile.target               |    1 +
>  arch_init.c                   | 1754 ++---------------------------------------
>  include/migration/migration.h |    2 +
>  include/sysemu/arch_init.h    |    1 -
>  migration/ram.c               | 1681 +++++++++++++++++++++++++++++++++++++++
>  trace-events                  |    2 +-
>  7 files changed, 1747 insertions(+), 1695 deletions(-)
>  create mode 100644 migration/ram.c

This diff is harder than necessary to read.  It can be made smaller by
using the --patience argument when creating the diff:

$ git diff HEAD^ --patience --stat
 MAINTAINERS                   |    1 -
 Makefile.target               |    1 +
 arch_init.c                   | 1630
---------------------------------------
 include/migration/migration.h |    2 +
 include/sysemu/arch_init.h    |    1 -
 migration/ram.c               | 1681
+++++++++++++++++++++++++++++++++++++++++
 trace-events                  |    2 +-
 7 files changed, 1685 insertions(+), 1633 deletions(-)


To make it permanent:
$ git config diff.algorithm patience

At any rate, here's how I reviewed:

$ diff -u <(git diff HEAD^ | sed -n 's/^-//p') <(git diff HEAD^ | sed -n
's/^\+//p')

You introduced a newline before mig_sleep_cpu(), and changed the text in
the DPRINTF definition, but I can live with that.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]