From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm: gic-v3: Implement correctly the callback send_SGI Date: Fri, 8 May 2015 15:27:52 +0100 Message-ID: <554CC7E8.1010402@citrix.com> References: <1430159464-24599-1-git-send-email-julien.grall@citrix.com> <553F616A.3020008@citrix.com> <1431093742.2660.469.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YqjHN-0006pC-C3 for xen-devel@lists.xenproject.org; Fri, 08 May 2015 14:29:29 +0000 In-Reply-To: <1431093742.2660.469.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Julien Grall Cc: xen-devel@lists.xenproject.org, Chen Baozi , tim@xen.org, stefano.stabellini@citrix.com, Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 08/05/15 15:02, Ian Campbell wrote: > On Tue, 2015-04-28 at 11:31 +0100, Julien Grall wrote: >> Hi Stefano, >> >> On 28/04/15 11:00, Stefano Stabellini wrote: >>> On Mon, 27 Apr 2015, Julien Grall wrote: >>>> diff --git a/xen/include/asm-arm/gic_v3_defs.h b/xen/include/asm-arm/gic_v3_defs.h >>>> index b8a1c2e..556f114 100644 >>>> --- a/xen/include/asm-arm/gic_v3_defs.h >>>> +++ b/xen/include/asm-arm/gic_v3_defs.h >>>> @@ -147,7 +147,7 @@ >>>> >>>> #define ICH_SGI_IRQMODE_SHIFT 40 >>>> #define ICH_SGI_IRQMODE_MASK 0x1 >>>> -#define ICH_SGI_TARGET_OTHERS 1 >>>> +#define ICH_SGI_TARGET_OTHERS 1UL >>> >>> Spurious change? >> >> No, this was a mistake when the GICv3 driver has been imported. The >> IRQMODE bit is 40 and 1 << 40 would throw the error: >> >> gic-v3.c:847:9: error: left shift count >= width of type [-Werror] >> WRITE_SYSREG(ICH_SGI_TARGET_OTHERS << ICH_SGI_IRQMODE_SHIFT | >> ^ > > I think you want 1ULL then so it is definitely always 64-bit. This header is using UL for 64-bit. I know that Vijay's is planning to import more define for Linux which use UL for 64-bit. I'd like to keep 1UL for consistency. FWIW, GICv3 is only built for ARM64. Regards, -- Julien Grall