From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, Jason Wang <jasowang@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] net: Change help text to list -netdev instead of -net by default
Date: Fri, 08 May 2015 16:39:49 +0200 [thread overview]
Message-ID: <554CCAB5.3030000@redhat.com> (raw)
In-Reply-To: <1431077765-6461-1-git-send-email-thuth@redhat.com>
On 08/05/2015 11:36, Thomas Huth wrote:
> Looking at the output of "qemu-system-xxx -help", you easily get
> the impression that "-net" is the preferred way instead of "-netdev"
> to specify host network interface, since the "-net" option is
> omnipresent but the "-netdev" option is only listed as a one-liner
> at the end. This is ugly since "-net" is considered as legacy and
> even might be removed one day. Thus, this patch switches the output
> to explain the host network interfaces with the "-netdev" option
> instead, moving the legacy "-net" option into some few lines at
> the end.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> qemu-options.hx | 66 ++++++++++++++++++++++++++++++++++-----------------------
> 1 file changed, 39 insertions(+), 27 deletions(-)
That would be great if it worked for all machine types, but it doesn't.
For example, there's no equivalent of:
$ qemu-system-arm -net user -net nic -machine versatilepb
You cannot just use -netdev:
$ qemu-system-arm -netdev user,id=nd0 -machine versatilepb
Warning: netdev nd0 has no peer
You cannot use -netdev and -net together:
$ qemu-system-arm -netdev user,id=nd0 -net nic -machine versatilepb
Warning: vlan 0 is not connected to host network
Warning: netdev nd0 has no peer
This particular board has a PCI controller, so you can just add a PCI
NIC using -netdev/-device, but still that wouldn't be a match for "-net
user -net nic" (which puts a smc91c111 NIC on sysbus). In most embedded
boards there's not even a PCI controller.
So the patch is great, but I wouldn't say it's deprecated, because in
practice it isn't.
Paolo
next prev parent reply other threads:[~2015-05-08 14:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 9:36 [Qemu-devel] [PATCH] net: Change help text to list -netdev instead of -net by default Thomas Huth
2015-05-08 12:44 ` Markus Armbruster
2015-05-09 7:47 ` Thomas Huth
2015-05-08 14:39 ` Paolo Bonzini [this message]
2015-05-09 7:51 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554CCAB5.3030000@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.