From: Michael Wood <michael.g.wood@intel.com>
To: "Damian, Alexandru" <alexandru.damian@intel.com>
Cc: "toaster@yoctoproject.org" <toaster@yoctoproject.org>
Subject: Re: [review-request] adamian/20150507_toasterui_fixes
Date: Fri, 08 May 2015 17:53:22 +0100 [thread overview]
Message-ID: <554CEA02.60707@intel.com> (raw)
In-Reply-To: <554CE6D6.3030602@intel.com>
Spotted one error I think
The project page link r'^project/(?P<pid>\d+)$' should be
r'^project/(?P<pid>\d+)/$
i.e.
- url(r'^project/(?P<pid>\d+)$', 'project', name='project'),
+ url(r'^project/(?P<pid>\d+)/$', 'project', name='project'),
Your django might not have reloaded the urls so didn't catch it maybe?
recreate:
1. go to /projects/
2. Select a project - 404
Michael
On 08/05/15 17:39, Michael Wood wrote:
> Looks fine to me.
>
> Michael
>
> On 07/05/15 18:13, Damian, Alexandru wrote:
>> Hello,
>>
>> This a refactoring of the URL structure to be more REST-ful.
>> It remove the usage of the server-side user session to remember
>> currently selected project, making navigation more robust, opening
>> API for usage to other tools, and passing the crawl test.
>>
>> Cheers,
>> Alex
>>
>> --
>> Alex Damian
>> Yocto Project
>> SSG / OTC
>>
>>
>
next prev parent reply other threads:[~2015-05-08 16:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 17:13 [review-request] adamian/20150507_toasterui_fixes Damian, Alexandru
[not found] ` <554CE6D6.3030602@intel.com>
2015-05-08 16:53 ` Michael Wood [this message]
2015-05-08 17:04 ` Damian, Alexandru
-- strict thread matches above, loose matches on Subject: below --
2015-05-12 17:18 Damian, Alexandru
2015-05-12 18:06 ` Michael Wood
2015-05-13 9:42 ` Damian, Alexandru
2015-05-13 13:10 ` Damian, Alexandru
2015-05-13 14:09 ` Michael Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554CEA02.60707@intel.com \
--to=michael.g.wood@intel.com \
--cc=alexandru.damian@intel.com \
--cc=toaster@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.