All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Nordell <tim.nordell@logicpd.com>
To: linux-omap@vger.kernel.org
Cc: linux-usb@vger.kernel.org
Subject: Re: DM3730 + MUSB host mode + DMA + USB Ethernet dongle = Fail
Date: Fri, 08 May 2015 13:24:46 -0500	[thread overview]
Message-ID: <554CFF6E.9020208@logicpd.com> (raw)
In-Reply-To: <554BE351.7070908@logicpd.com>

On 05/07/15 17:12, Tim Nordell wrote:
> On 05/07/15 16:41, Tim Nordell wrote:
>> I'm going to try another test which limits the TX or RX activity to PIO
>> mode only just to see what happens if I avoid the trigger listed in that
>> specific errata (despite the workaround for the errata being present).
>
> The system survives this.  I'm not sure if it's just because of
> different usages of the system, or if because there is still an issue
> with TX/RX DMA at the same time despite the advisory for the hardware
> still being followed.
>

I was wrong about the MUSB code implementing the advisory correctly.  I 
misread the advisory as saying 32-bit aligned when in fact it says 
32-byte aligned.  The additional constraints for the DMA advisory on the 
DM37x states that for Tx DMA packets, the data should be 32-byte aligned 
(Rx can go to any alignment still).  It also has payload size 
constraints for both Rx and Tx which aren't checked in the existing MUSB 
driver.

Doing some testing, the USB networking stack isn't sending 32-byte 
aligned buffers so I can't double check to see if this completely fixes 
it or if it's just masking it by adding some additional checks.  For our 
system, we're going to leave the Tx DMAs completely disabled.

At some point a patch should be developed which follows Advisory 1.81 
for the DM3730 part.

- Tim



  reply	other threads:[~2015-05-08 18:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06 23:17 DM3730 + MUSB host mode + DMA + USB Ethernet dongle = Fail Tim Nordell
     [not found] ` <554AA11B.9040909-L+YfUVVR8+RBDgjK7y7TUQ@public.gmane.org>
2015-05-07 16:06   ` Tony Lindgren
     [not found]     ` <20150507160606.GB15563-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-05-07 16:16       ` Felipe Balbi
     [not found]         ` <20150507161656.GB29183-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-05-07 18:17           ` Tim Nordell
     [not found]             ` <554BAC48.2050406-L+YfUVVR8+RBDgjK7y7TUQ@public.gmane.org>
2015-05-07 21:07               ` Chan-Taek Park
     [not found]                 ` <CAPM0aKVSJfyBj-FzdTDC+PFmHOmch39F26OF_0CzK5a704AVpA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-07 21:21                   ` Bin Liu
     [not found]                     ` <CADYTM3YGgm9b+vpxH8jJk41Cc9no=-pPydfHQsvR1FehbRCTxw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-07 21:26                       ` Tim Nordell
2015-05-07 21:41                         ` Tim Nordell
2015-05-07 22:12                           ` Tim Nordell
2015-05-08 18:24                             ` Tim Nordell [this message]
     [not found]                               ` <554CFF6E.9020208-L+YfUVVR8+RBDgjK7y7TUQ@public.gmane.org>
2015-05-08 21:11                                 ` Ruslan Bilovol

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554CFF6E.9020208@logicpd.com \
    --to=tim.nordell@logicpd.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.