From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:52659 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752809AbbEHSnX (ORCPT ); Fri, 8 May 2015 14:43:23 -0400 Message-ID: <554D03C2.8030106@kernel.org> Date: Fri, 08 May 2015 14:43:14 -0400 From: Jonathan Cameron MIME-Version: 1.0 To: Xander Huff , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org CC: michal.simek@xilinx.com, soren.brinkmann@xilinx.com, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, ben.shelton@ni.com, joshc@ni.com, joe.hershberger@ni.com Subject: Re: [PATCH 1/2] devicetree: xilinx-xadc: Add optional xlnx,extend-name property References: <1431038644-41600-1-git-send-email-xander.huff@ni.com> In-Reply-To: <1431038644-41600-1-git-send-email-xander.huff@ni.com> Content-Type: text/plain; charset=windows-1252 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 07/05/15 18:44, Xander Huff wrote: > To better facilitate user-mode access to optional aux channels, allow > device trees to specify a custom extended name for defined channels. > > Signed-off-by: Xander Huff > Reviewed-by: Joe Hershberger > Reviewed-by: Josh Cartwright > -- > Natinst-ReviewBoard-ID: 97119 Interesting idea. I'd like to let this sit for a fair while to see what comments it gets. If it makes sense for this driver, it probably makes sense for a lot of others. As such we may well want to have a general binding for this, rather than one for just this part. Thanks, Jonathan > --- > Documentation/devicetree/bindings/iio/adc/xilinx-xadc.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/xilinx-xadc.txt b/Documentation/devicetree/bindings/iio/adc/xilinx-xadc.txt > index d71258e..4c5a60b 100644 > --- a/Documentation/devicetree/bindings/iio/adc/xilinx-xadc.txt > +++ b/Documentation/devicetree/bindings/iio/adc/xilinx-xadc.txt > @@ -68,6 +68,8 @@ Optional properties: > Note each channel number should only be used at most > once. > Optional properties: > + * xlnx,extend-name: Custom extended name for the > + channel. > * xlnx,bipolar: If set the channel is used in bipolar > mode. > > @@ -107,6 +109,7 @@ Examples: > #size-cells = <0>; > channel@0 { > reg = <0>; > + xlnx,extend-name = "vin_v"; > xlnx,bipolar; > }; > }; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: jic23@kernel.org (Jonathan Cameron) Date: Fri, 08 May 2015 14:43:14 -0400 Subject: [PATCH 1/2] devicetree: xilinx-xadc: Add optional xlnx, extend-name property In-Reply-To: <1431038644-41600-1-git-send-email-xander.huff@ni.com> References: <1431038644-41600-1-git-send-email-xander.huff@ni.com> Message-ID: <554D03C2.8030106@kernel.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/05/15 18:44, Xander Huff wrote: > To better facilitate user-mode access to optional aux channels, allow > device trees to specify a custom extended name for defined channels. > > Signed-off-by: Xander Huff > Reviewed-by: Joe Hershberger > Reviewed-by: Josh Cartwright > -- > Natinst-ReviewBoard-ID: 97119 Interesting idea. I'd like to let this sit for a fair while to see what comments it gets. If it makes sense for this driver, it probably makes sense for a lot of others. As such we may well want to have a general binding for this, rather than one for just this part. Thanks, Jonathan > --- > Documentation/devicetree/bindings/iio/adc/xilinx-xadc.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/xilinx-xadc.txt b/Documentation/devicetree/bindings/iio/adc/xilinx-xadc.txt > index d71258e..4c5a60b 100644 > --- a/Documentation/devicetree/bindings/iio/adc/xilinx-xadc.txt > +++ b/Documentation/devicetree/bindings/iio/adc/xilinx-xadc.txt > @@ -68,6 +68,8 @@ Optional properties: > Note each channel number should only be used at most > once. > Optional properties: > + * xlnx,extend-name: Custom extended name for the > + channel. > * xlnx,bipolar: If set the channel is used in bipolar > mode. > > @@ -107,6 +109,7 @@ Examples: > #size-cells = <0>; > channel at 0 { > reg = <0>; > + xlnx,extend-name = "vin_v"; > xlnx,bipolar; > }; > }; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH 1/2] devicetree: xilinx-xadc: Add optional xlnx,extend-name property Date: Fri, 08 May 2015 14:43:14 -0400 Message-ID: <554D03C2.8030106@kernel.org> References: <1431038644-41600-1-git-send-email-xander.huff@ni.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1431038644-41600-1-git-send-email-xander.huff-acOepvfBmUk@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Xander Huff , robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org Cc: michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org, soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org, knaack.h-Mmb7MZpHnFY@public.gmane.org, lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org, pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ben.shelton-acOepvfBmUk@public.gmane.org, joshc-acOepvfBmUk@public.gmane.org, joe.hershberger-acOepvfBmUk@public.gmane.org List-Id: devicetree@vger.kernel.org On 07/05/15 18:44, Xander Huff wrote: > To better facilitate user-mode access to optional aux channels, allow > device trees to specify a custom extended name for defined channels. > > Signed-off-by: Xander Huff > Reviewed-by: Joe Hershberger > Reviewed-by: Josh Cartwright > -- > Natinst-ReviewBoard-ID: 97119 Interesting idea. I'd like to let this sit for a fair while to see what comments it gets. If it makes sense for this driver, it probably makes sense for a lot of others. As such we may well want to have a general binding for this, rather than one for just this part. Thanks, Jonathan > --- > Documentation/devicetree/bindings/iio/adc/xilinx-xadc.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/xilinx-xadc.txt b/Documentation/devicetree/bindings/iio/adc/xilinx-xadc.txt > index d71258e..4c5a60b 100644 > --- a/Documentation/devicetree/bindings/iio/adc/xilinx-xadc.txt > +++ b/Documentation/devicetree/bindings/iio/adc/xilinx-xadc.txt > @@ -68,6 +68,8 @@ Optional properties: > Note each channel number should only be used at most > once. > Optional properties: > + * xlnx,extend-name: Custom extended name for the > + channel. > * xlnx,bipolar: If set the channel is used in bipolar > mode. > > @@ -107,6 +109,7 @@ Examples: > #size-cells = <0>; > channel@0 { > reg = <0>; > + xlnx,extend-name = "vin_v"; > xlnx,bipolar; > }; > }; >