Re: [Qemu-devel] [PATCH] util/hbitmap: Add an API to reset all set bits in hbitmap

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 977 bytes --]

On 05/07/2015 07:12 PM, Wen Congyang wrote:
> The function bdrv_clear_dirty_bitmap() is updated to use
> faster hbitmap_reset_all() call.
> 
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  block.c                |  2 +-
>  include/qemu/hbitmap.h |  8 ++++++++
>  tests/test-hbitmap.c   | 38 ++++++++++++++++++++++++++++++++++++++
>  util/hbitmap.c         | 13 +++++++++++++
>  4 files changed, 60 insertions(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>


> +void hbitmap_reset_all(HBitmap *hb)
> +{
> +    unsigned int i;
> +
> +    /* Same as hbitmap_alloc() except memset() */

maybe s/except memset()/except for memset() instead of malloc()/

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]