From: "Lu, Baolu" <baolu.lu@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/3] usb: xhci: remove stop device and ring doorbell in hub control and bus suspend
Date: Sat, 09 May 2015 07:37:38 +0800 [thread overview]
Message-ID: <554D48C2.4070402@linux.intel.com> (raw)
In-Reply-To: <20150508110112.GB30150@kroah.com>
On 05/08/2015 07:01 PM, Greg Kroah-Hartman wrote:
> On Fri, May 08, 2015 at 06:26:28PM +0800, Lu Baolu wrote:
>> There is no need to call xhci_stop_device() and xhci_ring_device() in
>> hub control and bus suspend functions since all device suspend and
>> resume have been notified through device_suspend/device_resume interfaces.
> Does this mean that after patch 2, things are broken and require this
> patch to prevent problems?
No. things work well without patch 3. "stop device" and "ring doorbell"
operations in hub control and bus suspend is harmless, but duplicated
and unnecessary, so I remove them.
>
> I don't want to have any patch to make the system unstable.
>
> thanks,
>
> greg k-h
Thank you,
Baolu
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
prev parent reply other threads:[~2015-05-08 23:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 10:26 [PATCH v4 0/3] usb: notify hcd when USB device suspend or resume Lu Baolu
2015-05-08 10:26 ` [PATCH v4 1/3] " Lu Baolu
2015-05-08 14:35 ` Alan Stern
2015-05-08 10:26 ` [PATCH v4 2/3] usb: xhci: implement device_suspend/device_resume entries Lu Baolu
2015-05-08 10:26 ` [PATCH v4 3/3] usb: xhci: remove stop device and ring doorbell in hub control and bus suspend Lu Baolu
2015-05-08 11:01 ` Greg Kroah-Hartman
2015-05-08 23:37 ` Lu, Baolu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554D48C2.4070402@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.