Re: [PATCHv2 1/4] Use off_t and off64_t instead of __off_t and __off64_t

[Gregor Jasny <gjasny@googlemail.com>]

Hello,

Due to complete lack of unit / integration tests I feel uncomfortable
merging this patch without the ACK of Hans de Goede.

On 05/05/15 21:02, Felix Janda wrote:
> Since _LARGEFILE64_SOURCE is 1, these types coincide if defined.

This statement is only partially true:

$ git grep _LARGEFILE64_SOURCE
lib/libv4l1/v4l1compat.c:#define _LARGEFILE64_SOURCE 1
lib/libv4l2/v4l2convert.c:#define _LARGEFILE64_SOURCE 1

So LARGEFILE64_SOURCE will be only defined within the wrappers.
But libv4lsyscall-priv.h / SYS_MMAP is also used elsewhere.

But I wonder why SYS_MMAP is there in the first place? Maybe because in
the LD_PRELOAD case the default mmap symbol resolves to our wrapper?
But in that case can't we gently ask the loader to give us the next
symbol in the chain via dlsym(RTLD_NEXT, "mmap")?

Thanks,
Gregor