All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philippe Reynes <tremyfr@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: "Russell King - ARM Linux" <linux@arm.linux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	"Duan Fugang-B38611" <B38611@freescale.com>,
	"Frank Li" <Frank.Li@freescale.com>,
	"Lothar Waßmann" <LW@karo-electronics.de>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: fec: add support of ethtool get_regs
Date: Sun, 10 May 2015 00:16:21 +0200	[thread overview]
Message-ID: <554E8735.302@gmail.com> (raw)
In-Reply-To: <CAOMZO5A2POPCYHzotc5SEhtmCuBrXiK7bdjF=UeiXZEqcnGMag@mail.gmail.com>

Hi Fabio,

On 09/05/15 23:59, Fabio Estevam wrote:
> Philippe,
>
> On Sat, May 9, 2015 at 6:17 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk>  wrote:
>
>> Using memcpy_fromio() to copy device registers is not a good idea -
>> it can use a variable access size which can cause bus faults.
>
> An example on how memcpy_fromio() can be avoided in get_regs:
> drivers/net/ethernet/samsung/sxgbe/sxgbe_ethtool.c

Thanks for pointing me this example. I've already send a patch,
and I've used drivers/net/ethernet/freescale/gianfar_ethtool.c
as example. I hope it's a good example too.

> Regards,
>
> Fabio Estevam

Regards,
Philippe

  reply	other threads:[~2015-05-09 22:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-09 20:52 [PATCH] net: fec: add support of ethtool get_regs Philippe Reynes
2015-05-09 21:17 ` Russell King - ARM Linux
2015-05-09 21:31   ` David Miller
2015-05-09 21:59   ` Fabio Estevam
2015-05-09 22:16     ` Philippe Reynes [this message]
2015-05-10  1:01       ` David Miller
2015-05-10 21:43         ` Philippe Reynes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554E8735.302@gmail.com \
    --to=tremyfr@gmail.com \
    --cc=B38611@freescale.com \
    --cc=Frank.Li@freescale.com \
    --cc=LW@karo-electronics.de \
    --cc=davem@davemloft.net \
    --cc=festevam@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.