All of lore.kernel.org
 help / color / mirror / Atom feed
From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	Bart Van Assche
	<bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH RFC] IB/core, cma: Nice log-friendly string helpers
Date: Sun, 10 May 2015 15:04:21 +0300	[thread overview]
Message-ID: <554F4945.8080000@mellanox.com> (raw)
In-Reply-To: <1431252274-27739-1-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

On 5/10/2015 1:04 PM, Sagi Grimberg wrote:
> Some of us keep revisiting the code to decode IB/RDMA_CM enumerations
> that appear in our logs. Let's borrow the nice logging helpers xprtrdma
> has for CMA events, IB events and WC statuses. Also, have srp, iser and
> isert be early adopters.
>
> Signed-off-by: Sagi Grimberg<sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> I have been using this patch for some time now so I thought
> it would be nice to get it out.
>
>   drivers/infiniband/ulp/iser/iser_verbs.c |   25 +++++---
>   drivers/infiniband/ulp/srp/ib_srp.c      |   15 +++--
>   include/rdma/ib_verbs.h                  |   55 ++++++++++++++++++
>   include/rdma/rdma_cm.h                   |   23 ++++++++
>   net/sunrpc/xprtrdma/verbs.c              |   90 ++----------------------------
>   5 files changed, 106 insertions(+), 102 deletions(-)

Nice initiative (was on my Q for years...), please make sure to plug 
into the RDS code into this party, that isre-use their 
RDS_IB_EVENT_STRING, RDS_CM_EVENT_STRING and such to avoid us declaring 
the same strings over and over.

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-05-10 12:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1431252274-27739-1-git-send-email-sagig@mellanox.com>
     [not found] ` <1431252274-27739-1-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-05-10 10:29   ` [PATCH RFC] IB/core, cma: Nice log-friendly string helpers Bart Van Assche
     [not found]     ` <554F32F3.1070308-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-05-10 10:45       ` Sagi Grimberg
     [not found]         ` <554F36BC.5070009-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-05-11  7:50           ` Bart Van Assche
2015-05-10 12:04   ` Or Gerlitz [this message]
2015-05-10 10:36 Sagi Grimberg
     [not found] ` <1431254186-23554-1-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-05-10 20:22   ` Or Gerlitz
     [not found] <1431253542-14933-1-git-send-email-sagig@mellanox.com>
     [not found] ` <1431253542-14933-1-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-05-11 13:44   ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554F4945.8080000@mellanox.com \
    --to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
    --cc=bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
    --cc=chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.