Re: [XEN PATCH] automation/eclair_analysis: file exclusion automation

[Nicola Vetrini <nicola.vetrini@bugseng.com>]

On 2023-12-07 18:56, Julien Grall wrote:
> Hi Nicola,
> 
> On 07/12/2023 17:53, Nicola Vetrini wrote:
>> On 2023-12-07 18:08, Julien Grall wrote:
>>> On 07/12/2023 11:39, Nicola Vetrini wrote:
>>>> +-doc_begin="libfdt is out of scope."
>>>> +-file_tag+={out_of_scope,"^xen/include/xen/libfdt/.*$"}
>>> 
>>> AFAICT, before this was marked as "adopted". But this is now moved to 
>>> "out_of_scope". Can you explain why?
>>> 
>>> It also feels somewhat unrelated to the rest of the patch.
>>> 
>>> Cheers,
>> 
>> I mistakenly changed the tag. It is not unrelated, as it't not part of 
>> exclude-list.json (perhaps unintentionally). The manual exclusions 
>> that remain in out_of_scope.ecl are there for this reason, since I 
>> wanted to keep the set of excluded files as it was before.
> 
> Given that common/libfdt/* is part of the exclude-list.json, I can't 
> see why include/xen/libfdt/* are not. So can you add it?
> 
> Cheers,

Sure, I will.

-- 
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)