Re: 4.0.2-stable-queue build failures due to 'clockevents: Fix cpu_down() race for hrtimer based broadcasting'

[Preeti U Murthy <preeti@linux.vnet.ibm.com>]

On 05/11/2015 06:29 AM, Guenter Roeck wrote:
> Build is still going on, so there may be other affected architectures.
> 
> ---
> 
> Building ia64:defconfig ... failed
> Building parisc:generic-32bit_defconfig ... failed
> --------------
> Error log:
> kernel/cpu.c: In function '_cpu_down':
> kernel/cpu.c:415:2: error: implicit declaration of function
> 'hotplug_cpu__broadcast_tick_pull' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> 
> ---
> 
> Bisect log:
> 
> # bad: [c71309a3658d323d56261d4590b2c5214e61b05f] clockevents: Fix
> cpu_down() race for hrtimer based broadcasting
> # good: [072cab659c9368586d6417cfd6ec2d2c68469c67] Linux 4.0.2
> git bisect start 'HEAD' 'v4.0.2'
> # good: [7e62c9a30d01ac14be2bc3e048b737e1b0c8d08d] cdc-acm: prevent
> infinite loop when parsing CDC headers.
> git bisect good 7e62c9a30d01ac14be2bc3e048b737e1b0c8d08d
> # good: [8b55f847f1e9964ac2ab657cc0e1334ed8be214c] ext4: fix data
> corruption caused by unwritten and delayed extents
> git bisect good 8b55f847f1e9964ac2ab657cc0e1334ed8be214c
> # good: [7c0e04a5e08bec7f9101d20214f92b5f466a556b] drm/radeon: only mark
> audio as connected if the monitor supports it (v3)
> git bisect good 7c0e04a5e08bec7f9101d20214f92b5f466a556b
> # good: [da9778d808f0629fd804421e97294f25b81b1885] drm/radeon: fix
> lockup when BOs aren't part of the VM on release
> git bisect good da9778d808f0629fd804421e97294f25b81b1885
> # good: [68cd28ab24ce16ac7f3978a7627eae5b599c3d8b] drm/radeon: check new
> address before removing old one
> git bisect good 68cd28ab24ce16ac7f3978a7627eae5b599c3d8b
> # good: [c20b6545f649724a733e008e7124fa9d1e114c71] Drivers: hv: vmbus:
> Don't wait after requesting offers
> git bisect good c20b6545f649724a733e008e7124fa9d1e114c71
> # first bad commit: [c71309a3658d323d56261d4590b2c5214e61b05f]
> clockevents: Fix cpu_down() race for hrtimer based broadcasting
> 
> ---
> 
> Reverting the bad commit fixes the problem.

Please let me know if the following patch fixes the issue:

    clockevents: Fix build error caused by fix for hotplug race with hrtimer broadcast
    
    commit: c71309a3658d ("clockevents: Fix cpu_down() race for hrtimer based broadcasting")
    causes a build error on certain archs where CONFIG_GENERIC_CLOCKEVENTS
    is not set. This patch fixes this.
    
    Signed-off-by: Preeti U. Murthy <preeti@linux.vnet.ibm.com>

diff --git a/include/linux/tick.h b/include/linux/tick.h
index e3e9d20..b62ff06 100644
--- a/include/linux/tick.h
+++ b/include/linux/tick.h
@@ -134,6 +134,7 @@ static inline void tick_clock_notify(void) { }
 static inline int tick_check_oneshot_change(int allow_nohz) { return 0; }
 static inline void tick_irq_enter(void) { }
 static inline int tick_oneshot_mode_active(void) { return 0; }
+static inline void hotplug_cpu__broadcast_tick_pull(int dead_cpu) { }
 #endif /* !CONFIG_GENERIC_CLOCKEVENTS */
 
 # ifdef CONFIG_NO_HZ_COMMON


Thanks

Regards
Preeti U Murthy
> 
> Guenter
>