From: Paolo Bonzini <pbonzini@redhat.com>
To: shannon.zhao@linaro.org, qemu-devel@nongnu.org,
peter.maydell@linaro.org, cornelia.huck@de.ibm.com,
mst@redhat.com
Cc: hangaohuai@huawei.com, peter.huangpeng@huawei.com,
christoffer.dall@linaro.org, zhaoshenglong@huawei.com
Subject: Re: [Qemu-devel] [PATCH 0/3] virtio-balloon: use alias property
Date: Mon, 11 May 2015 12:14:22 +0200 [thread overview]
Message-ID: <555080FE.3060607@redhat.com> (raw)
In-Reply-To: <1431336847-4104-1-git-send-email-shannon.zhao@linaro.org>
On 11/05/2015 11:34, shannon.zhao@linaro.org wrote:
> From: Shannon Zhao <shannon.zhao@linaro.org>
>
> The wrappers of virtio-balloon are using object_property_add to add
> properties and all have their own getters/setters which are duplicate of
> those in virtio-balloon device. So this patchset uses
> object_property_add_alias for these properties as Paolo suggested.
>
> Shannon Zhao (3):
> hw/virtio/virtio-balloon: move adding property to
> virtio_balloon_instance_init
> hw/virtio/virtio-pci: use alias property for virtio-balloon-pci
> hw/s390x/virtio-ccw: use alias property for virtio-balloon-ccw
>
> hw/s390x/virtio-ccw.c | 39 ++++++---------------------------------
> hw/virtio/virtio-balloon.c | 22 ++++++++++++++--------
> hw/virtio/virtio-pci.c | 40 ++++++----------------------------------
> 3 files changed, 26 insertions(+), 75 deletions(-)
>
Nice.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2015-05-11 10:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 9:34 [Qemu-devel] [PATCH 0/3] virtio-balloon: use alias property shannon.zhao
2015-05-11 9:34 ` [Qemu-devel] [PATCH 1/3] hw/virtio/virtio-balloon: move adding property to virtio_balloon_instance_init shannon.zhao
2015-05-11 10:13 ` Paolo Bonzini
2015-05-11 9:34 ` [Qemu-devel] [PATCH 2/3] hw/virtio/virtio-pci: use alias property for virtio-balloon-pci shannon.zhao
2015-05-11 9:34 ` [Qemu-devel] [PATCH 3/3] hw/s390x/virtio-ccw: use alias property for virtio-balloon-ccw shannon.zhao
2015-05-11 10:14 ` Paolo Bonzini [this message]
2015-05-11 12:02 ` [Qemu-devel] [PATCH 0/3] virtio-balloon: use alias property Cornelia Huck
2015-05-20 1:09 ` Shannon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555080FE.3060607@redhat.com \
--to=pbonzini@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=cornelia.huck@de.ibm.com \
--cc=hangaohuai@huawei.com \
--cc=mst@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhao@linaro.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.