From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH v2 2/6] libxc/restore: Bail if unknown options are found Date: Mon, 11 May 2015 11:43:46 +0100 Message-ID: <555087E2.5050200@citrix.com> References: <1431119675-23847-1-git-send-email-andrew.cooper3@citrix.com> <1431119675-23847-3-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1431119675-23847-3-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , Xen-devel Cc: Ian Jackson , Yang Hongyang , Wei Liu , Ian Campbell , David Vrabel List-Id: xen-devel@lists.xenproject.org On 08/05/15 22:14, Andrew Cooper wrote: > When restoring a domain, check for unknown options in Image Header. Nothing > good will come from attempting to continue. Section 2.3 (Fields) explicitly states that "Padding and reserved fields are set to zero on save and must be ignored during restore". I don't think there is a compelling reason to change this behaviour for this particular field. David