From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 6/8] qcow2: make qcow2_cache_put() a void function
Date: Mon, 11 May 2015 15:12:35 +0200 [thread overview]
Message-ID: <5550AAC3.5060601@redhat.com> (raw)
In-Reply-To: <7714974c1f563a85daa35a64036dffe06442370d.1431348770.git.berto@igalia.com>
On 11.05.2015 14:54, Alberto Garcia wrote:
> This function never receives an invalid table pointer, so we can make
> it void and remove all the error checking code.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> block/qcow2-cache.c | 7 +------
> block/qcow2-cluster.c | 50 ++++++++++----------------------------------------
> block/qcow2-refcount.c | 29 +++++------------------------
> block/qcow2.h | 2 +-
> 4 files changed, 17 insertions(+), 71 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2015-05-11 13:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 12:54 [Qemu-devel] [PATCH v3 0/8] qcow2 L2/refcount cache improvements Alberto Garcia
2015-05-11 12:54 ` [Qemu-devel] [PATCH 1/8] qcow2: use one single memory block for the L2/refcount cache tables Alberto Garcia
2015-05-11 12:54 ` [Qemu-devel] [PATCH 2/8] qcow2: simplify qcow2_cache_put() and qcow2_cache_entry_mark_dirty() Alberto Garcia
2015-05-11 12:54 ` [Qemu-devel] [PATCH 3/8] qcow2: use an LRU algorithm to replace entries from the L2 cache Alberto Garcia
2015-05-11 12:54 ` [Qemu-devel] [PATCH 4/8] qcow2: remove qcow2_cache_find_entry_to_replace() Alberto Garcia
2015-05-11 12:54 ` [Qemu-devel] [PATCH 5/8] qcow2: use a hash to look for entries in the L2 cache Alberto Garcia
2015-05-11 12:54 ` [Qemu-devel] [PATCH 6/8] qcow2: make qcow2_cache_put() a void function Alberto Garcia
2015-05-11 13:12 ` Max Reitz [this message]
2015-05-11 12:54 ` [Qemu-devel] [PATCH 7/8] qcow2: style fixes in qcow2-cache.c Alberto Garcia
2015-05-11 12:55 ` [Qemu-devel] [PATCH 8/8] docs: document how to configure the qcow2 L2/refcount caches Alberto Garcia
2015-05-11 13:23 ` Max Reitz
2015-05-11 13:30 ` Alberto Garcia
2015-05-11 14:08 ` Max Reitz
2015-05-11 15:12 ` Eric Blake
2015-05-12 9:57 ` [Qemu-devel] [PATCH v3 0/8] qcow2 L2/refcount cache improvements Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5550AAC3.5060601@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.