From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Zapolskiy Subject: Re: [PATCH 2/4] gpio: gpio-generic: add flag to read out output value from reg_set Date: Mon, 11 May 2015 16:28:05 +0300 Message-ID: <5550AE65.8070401@mentor.com> References: <1430321701-13758-1-git-send-email-vladimir_zapolskiy@mentor.com> <1430321701-13758-3-git-send-email-vladimir_zapolskiy@mentor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from relay1.mentorg.com ([192.94.38.131]:61407 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752367AbbEKN2J (ORCPT ); Mon, 11 May 2015 09:28:09 -0400 In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij Cc: Alexandre Courbot , "linux-gpio@vger.kernel.org" On 11.05.2015 12:50, Linus Walleij wrote: > On Wed, Apr 29, 2015 at 5:34 PM, Vladimir Zapolskiy > wrote: > >> The change introduces BGPIOF_READ_OUTPUT_REG_SET flag for gpio-generic >> GPIO chip implementation, which allows to get correct configured value >> from reg_set register, input value is still get from reg_dat. >> >> Signed-off-by: Vladimir Zapolskiy > > Looks reasonable. Patch applied. > > Do we need device tree bindings for this? I don't think so, particular drivers have this as a fixed property, and "basic-mmio-gpio" has no device tree bindings. OTOH let see on dynamics of the flag usage, if it grows, it may happen that its negation is a better candidate for a quirk. -- With best wishes, Vladimir