From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [RFT PATCH v2 2/3] drm/exynos: Constify exynos_drm_crtc_ops Date: Mon, 11 May 2015 22:29:25 +0900 Message-ID: <5550AEB5.4020709@samsung.com> References: <1430957086-25005-1-git-send-email-k.kozlowski@samsung.com> <1430957086-25005-3-git-send-email-k.kozlowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <1430957086-25005-3-git-send-email-k.kozlowski@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Krzysztof Kozlowski Cc: linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , Jingoo Han , Seung-Woo Kim , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kyungmin Park , Kukjin Kim , Javier Martinez Canillas , linux-arm-kernel@lists.infradead.org List-Id: linux-samsung-soc@vger.kernel.org T24gMjAxNeuFhCAwNeyblCAwN+ydvCAwOTowNCwgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToK PiBGcm9tOiBLcnp5c3p0b2YgS296bG93c2tpIDxrLmtvemxvd3NraS5rQGdtYWlsLmNvbT4KPiAK PiBUaGUgRXh5bm9zIERSTSBjb2RlIGRvZXMgbm90IG1vZGlmeSB0aGUgb3BzIHByb3ZpZGVkIGJ5 IENSVEMgZHJpdmVyIGluCj4gZXh5bm9zX2RybV9jcnRjX2NyZWF0ZSgpIGNhbGwuCgpQbGVhc2Ug Y2hlY2sgY29kaW5nIHN0eWxlIHdpdGggY2hlY2twYXRjaC5wbCBiZWZvcmUgcG9zdGluZyBpdC4g SSBjYW4Kc2VlIGJlbG93IHdhcm5pbmcsCgpXQVJOSU5HOiBsaW5lIG92ZXIgODAgY2hhcmFjdGVy cwojMTQ2OiBGSUxFOiBkcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fY3J0Yy5jOjI0 NDoKKwkJCQkJICAgICAgIGNvbnN0IHN0cnVjdCBleHlub3NfZHJtX2NydGNfb3BzICpvcHMsCgpX QVJOSU5HOiBsaW5lIG92ZXIgODAgY2hhcmFjdGVycwojMTU5OiBGSUxFOiBkcml2ZXJzL2dwdS9k cm0vZXh5bm9zL2V4eW5vc19kcm1fY3J0Yy5oOjI0OgorCQkJCQkgICAgICAgY29uc3Qgc3RydWN0 IGV4eW5vc19kcm1fY3J0Y19vcHMgKm9wcywKCgpJIG1vZGlmaWVkIGFuZCBtZXJnZWQgYWxsIHBh dGNoZXMuCgpUaGFua3MsCklua2kgRGFlCgo+IAo+IFNpZ25lZC1vZmYtYnk6IEtyenlzenRvZiBL b3psb3dza2kgPGsua296bG93c2tpLmtAZ21haWwuY29tPgo+IAo+IC0tLQo+IENoYW5nZXMgc2lu Y2UgdjE6Cj4gTmV3IHBhdGNoLgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5v czdfZHJtX2RlY29uLmMgfCAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2Ry bV9jcnRjLmMgICB8IDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2Ny dGMuaCAgIHwgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZHJ2Lmgg ICAgfCAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RybV9maW1kLmMgICB8 IDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX3ZpZGkuYyAgIHwgMiAr LQo+ICBkcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19taXhlci5jICAgICAgfCAyICstCj4g IDcgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vczdfZHJtX2RlY29uLmMgYi9k cml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vczdfZHJtX2RlY29uLmMKPiBpbmRleCAxZjdlMzNm NTlkZTYuLjNkMDBkZjc2MjIwZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9z L2V4eW5vczdfZHJtX2RlY29uLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5v czdfZHJtX2RlY29uLmMKPiBAQCAtNzEwLDcgKzcxMCw3IEBAIHN0YXRpYyB2b2lkIGRlY29uX2Rw bXMoc3RydWN0IGV4eW5vc19kcm1fY3J0YyAqY3J0YywgaW50IG1vZGUpCj4gIAl9Cj4gIH0KPiAg Cj4gLXN0YXRpYyBzdHJ1Y3QgZXh5bm9zX2RybV9jcnRjX29wcyBkZWNvbl9jcnRjX29wcyA9IHsK PiArc3RhdGljIGNvbnN0IHN0cnVjdCBleHlub3NfZHJtX2NydGNfb3BzIGRlY29uX2NydGNfb3Bz ID0gewo+ICAJLmRwbXMgPSBkZWNvbl9kcG1zLAo+ICAJLm1vZGVfZml4dXAgPSBkZWNvbl9tb2Rl X2ZpeHVwLAo+ICAJLmNvbW1pdCA9IGRlY29uX2NvbW1pdCwKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2NydGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9leHlu b3MvZXh5bm9zX2RybV9jcnRjLmMKPiBpbmRleCBlYjQ5MTk1Y2VjNWMuLjkzZjg3M2YxMWY2NCAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fY3J0Yy5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2NydGMuYwo+IEBAIC0yNDEs NyArMjQxLDcgQEAgc3RydWN0IGV4eW5vc19kcm1fY3J0YyAqZXh5bm9zX2RybV9jcnRjX2NyZWF0 ZShzdHJ1Y3QgZHJtX2RldmljZSAqZHJtX2RldiwKPiAgCQkJCQkgICAgICAgc3RydWN0IGRybV9w bGFuZSAqcGxhbmUsCj4gIAkJCQkJICAgICAgIGludCBwaXBlLAo+ICAJCQkJCSAgICAgICBlbnVt IGV4eW5vc19kcm1fb3V0cHV0X3R5cGUgdHlwZSwKPiAtCQkJCQkgICAgICAgc3RydWN0IGV4eW5v c19kcm1fY3J0Y19vcHMgKm9wcywKPiArCQkJCQkgICAgICAgY29uc3Qgc3RydWN0IGV4eW5vc19k cm1fY3J0Y19vcHMgKm9wcywKPiAgCQkJCQkgICAgICAgdm9pZCAqY3R4KQo+ICB7Cj4gIAlzdHJ1 Y3QgZXh5bm9zX2RybV9jcnRjICpleHlub3NfY3J0YzsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2NydGMuaCBiL2RyaXZlcnMvZ3B1L2RybS9leHlub3Mv ZXh5bm9zX2RybV9jcnRjLmgKPiBpbmRleCAwZWNkOGZjNDVjZmYuLmVkMDk5NGIzY2I0NyAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fY3J0Yy5oCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2NydGMuaAo+IEBAIC0yMSw3ICsy MSw3IEBAIHN0cnVjdCBleHlub3NfZHJtX2NydGMgKmV4eW5vc19kcm1fY3J0Y19jcmVhdGUoc3Ry dWN0IGRybV9kZXZpY2UgKmRybV9kZXYsCj4gIAkJCQkJICAgICAgIHN0cnVjdCBkcm1fcGxhbmUg KnBsYW5lLAo+ICAJCQkJCSAgICAgICBpbnQgcGlwZSwKPiAgCQkJCQkgICAgICAgZW51bSBleHlu b3NfZHJtX291dHB1dF90eXBlIHR5cGUsCj4gLQkJCQkJICAgICAgIHN0cnVjdCBleHlub3NfZHJt X2NydGNfb3BzICpvcHMsCj4gKwkJCQkJICAgICAgIGNvbnN0IHN0cnVjdCBleHlub3NfZHJtX2Ny dGNfb3BzICpvcHMsCj4gIAkJCQkJICAgICAgIHZvaWQgKmNvbnRleHQpOwo+ICBpbnQgZXh5bm9z X2RybV9jcnRjX2VuYWJsZV92Ymxhbmsoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgaW50IHBpcGUp Owo+ICB2b2lkIGV4eW5vc19kcm1fY3J0Y19kaXNhYmxlX3ZibGFuayhzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2LCBpbnQgcGlwZSk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9leHlub3Mv ZXh5bm9zX2RybV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RybV9kcnYu aAo+IGluZGV4IDQ0ZjEyOGEwM2FlYS4uMGU5NTEyMjZjYTA2IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RybV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9leHlub3MvZXh5bm9zX2RybV9kcnYuaAo+IEBAIC0yMjYsNyArMjI2LDcgQEAgc3RydWN0IGV4 eW5vc19kcm1fY3J0YyB7Cj4gIAl1bnNpZ25lZCBpbnQJCQlkcG1zOwo+ICAJd2FpdF9xdWV1ZV9o ZWFkX3QJCXBlbmRpbmdfZmxpcF9xdWV1ZTsKPiAgCXN0cnVjdCBkcm1fcGVuZGluZ192Ymxhbmtf ZXZlbnQJKmV2ZW50Owo+IC0Jc3RydWN0IGV4eW5vc19kcm1fY3J0Y19vcHMJKm9wczsKPiArCWNv bnN0IHN0cnVjdCBleHlub3NfZHJtX2NydGNfb3BzCSpvcHM7Cj4gIAl2b2lkCQkJCSpjdHg7Cj4g IH07Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1f ZmltZC5jIGIvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2ZpbWQuYwo+IGluZGV4 IDJmYjk1Y2NiNTg0MS4uNWMxYTE0ODUyNWY4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9leHlub3MvZXh5bm9zX2RybV9maW1kLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZXh5bm9z L2V4eW5vc19kcm1fZmltZC5jCj4gQEAgLTk2Miw3ICs5NjIsNyBAQCBzdGF0aWMgdm9pZCBmaW1k X2RwX2Nsb2NrX2VuYWJsZShzdHJ1Y3QgZXh5bm9zX2RybV9jcnRjICpjcnRjLCBib29sIGVuYWJs ZSkKPiAgCXdyaXRlbChEUF9NSUVfQ0xLX0RQX0VOQUJMRSwgY3R4LT5yZWdzICsgRFBfTUlFX0NM S0NPTik7Cj4gIH0KPiAgCj4gLXN0YXRpYyBzdHJ1Y3QgZXh5bm9zX2RybV9jcnRjX29wcyBmaW1k X2NydGNfb3BzID0gewo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGV4eW5vc19kcm1fY3J0Y19vcHMg ZmltZF9jcnRjX29wcyA9IHsKPiAgCS5kcG1zID0gZmltZF9kcG1zLAo+ICAJLm1vZGVfZml4dXAg PSBmaW1kX21vZGVfZml4dXAsCj4gIAkuY29tbWl0ID0gZmltZF9jb21taXQsCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RybV92aWRpLmMgYi9kcml2ZXJzL2dw dS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fdmlkaS5jCj4gaW5kZXggMjdlODRlYzIxNjk0Li4xYjM0 NzlhOGRiNWYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJt X3ZpZGkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RybV92aWRpLmMK PiBAQCAtMjE3LDcgKzIxNyw3IEBAIHN0YXRpYyBpbnQgdmlkaV9jdHhfaW5pdGlhbGl6ZShzdHJ1 Y3QgdmlkaV9jb250ZXh0ICpjdHgsCj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiAtc3RhdGljIHN0 cnVjdCBleHlub3NfZHJtX2NydGNfb3BzIHZpZGlfY3J0Y19vcHMgPSB7Cj4gK3N0YXRpYyBjb25z dCBzdHJ1Y3QgZXh5bm9zX2RybV9jcnRjX29wcyB2aWRpX2NydGNfb3BzID0gewo+ICAJLmRwbXMg PSB2aWRpX2RwbXMsCj4gIAkuZW5hYmxlX3ZibGFuayA9IHZpZGlfZW5hYmxlX3ZibGFuaywKPiAg CS5kaXNhYmxlX3ZibGFuayA9IHZpZGlfZGlzYWJsZV92YmxhbmssCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX21peGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZXh5 bm9zL2V4eW5vc19taXhlci5jCj4gaW5kZXggZmJlYzc1MDU3NGU2Li5kNGFmZDFhYmUzNzMgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfbWl4ZXIuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX21peGVyLmMKPiBAQCAtMTEyNiw3ICsxMTI2 LDcgQEAgaW50IG1peGVyX2NoZWNrX21vZGUoc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUp Cj4gIAlyZXR1cm4gLUVJTlZBTDsKPiAgfQo+ICAKPiAtc3RhdGljIHN0cnVjdCBleHlub3NfZHJt X2NydGNfb3BzIG1peGVyX2NydGNfb3BzID0gewo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGV4eW5v c19kcm1fY3J0Y19vcHMgbWl4ZXJfY3J0Y19vcHMgPSB7Cj4gIAkuZHBtcwkJCT0gbWl4ZXJfZHBt cywKPiAgCS5lbmFibGVfdmJsYW5rCQk9IG1peGVyX2VuYWJsZV92YmxhbmssCj4gIAkuZGlzYWJs ZV92YmxhbmsJCT0gbWl4ZXJfZGlzYWJsZV92YmxhbmssCj4gCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: inki.dae@samsung.com (Inki Dae) Date: Mon, 11 May 2015 22:29:25 +0900 Subject: [RFT PATCH v2 2/3] drm/exynos: Constify exynos_drm_crtc_ops In-Reply-To: <1430957086-25005-3-git-send-email-k.kozlowski@samsung.com> References: <1430957086-25005-1-git-send-email-k.kozlowski@samsung.com> <1430957086-25005-3-git-send-email-k.kozlowski@samsung.com> Message-ID: <5550AEB5.4020709@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015? 05? 07? 09:04, Krzysztof Kozlowski wrote: > From: Krzysztof Kozlowski > > The Exynos DRM code does not modify the ops provided by CRTC driver in > exynos_drm_crtc_create() call. Please check coding style with checkpatch.pl before posting it. I can see below warning, WARNING: line over 80 characters #146: FILE: drivers/gpu/drm/exynos/exynos_drm_crtc.c:244: + const struct exynos_drm_crtc_ops *ops, WARNING: line over 80 characters #159: FILE: drivers/gpu/drm/exynos/exynos_drm_crtc.h:24: + const struct exynos_drm_crtc_ops *ops, I modified and merged all patches. Thanks, Inki Dae > > Signed-off-by: Krzysztof Kozlowski > > --- > Changes since v1: > New patch. > --- > drivers/gpu/drm/exynos/exynos7_drm_decon.c | 2 +- > drivers/gpu/drm/exynos/exynos_drm_crtc.c | 2 +- > drivers/gpu/drm/exynos/exynos_drm_crtc.h | 2 +- > drivers/gpu/drm/exynos/exynos_drm_drv.h | 2 +- > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +- > drivers/gpu/drm/exynos/exynos_drm_vidi.c | 2 +- > drivers/gpu/drm/exynos/exynos_mixer.c | 2 +- > 7 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos7_drm_decon.c b/drivers/gpu/drm/exynos/exynos7_drm_decon.c > index 1f7e33f59de6..3d00df76220d 100644 > --- a/drivers/gpu/drm/exynos/exynos7_drm_decon.c > +++ b/drivers/gpu/drm/exynos/exynos7_drm_decon.c > @@ -710,7 +710,7 @@ static void decon_dpms(struct exynos_drm_crtc *crtc, int mode) > } > } > > -static struct exynos_drm_crtc_ops decon_crtc_ops = { > +static const struct exynos_drm_crtc_ops decon_crtc_ops = { > .dpms = decon_dpms, > .mode_fixup = decon_mode_fixup, > .commit = decon_commit, > diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c > index eb49195cec5c..93f873f11f64 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c > @@ -241,7 +241,7 @@ struct exynos_drm_crtc *exynos_drm_crtc_create(struct drm_device *drm_dev, > struct drm_plane *plane, > int pipe, > enum exynos_drm_output_type type, > - struct exynos_drm_crtc_ops *ops, > + const struct exynos_drm_crtc_ops *ops, > void *ctx) > { > struct exynos_drm_crtc *exynos_crtc; > diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.h b/drivers/gpu/drm/exynos/exynos_drm_crtc.h > index 0ecd8fc45cff..ed0994b3cb47 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.h > +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.h > @@ -21,7 +21,7 @@ struct exynos_drm_crtc *exynos_drm_crtc_create(struct drm_device *drm_dev, > struct drm_plane *plane, > int pipe, > enum exynos_drm_output_type type, > - struct exynos_drm_crtc_ops *ops, > + const struct exynos_drm_crtc_ops *ops, > void *context); > int exynos_drm_crtc_enable_vblank(struct drm_device *dev, int pipe); > void exynos_drm_crtc_disable_vblank(struct drm_device *dev, int pipe); > diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exynos/exynos_drm_drv.h > index 44f128a03aea..0e951226ca06 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_drv.h > +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h > @@ -226,7 +226,7 @@ struct exynos_drm_crtc { > unsigned int dpms; > wait_queue_head_t pending_flip_queue; > struct drm_pending_vblank_event *event; > - struct exynos_drm_crtc_ops *ops; > + const struct exynos_drm_crtc_ops *ops; > void *ctx; > }; > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > index 2fb95ccb5841..5c1a148525f8 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > @@ -962,7 +962,7 @@ static void fimd_dp_clock_enable(struct exynos_drm_crtc *crtc, bool enable) > writel(DP_MIE_CLK_DP_ENABLE, ctx->regs + DP_MIE_CLKCON); > } > > -static struct exynos_drm_crtc_ops fimd_crtc_ops = { > +static const struct exynos_drm_crtc_ops fimd_crtc_ops = { > .dpms = fimd_dpms, > .mode_fixup = fimd_mode_fixup, > .commit = fimd_commit, > diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exynos/exynos_drm_vidi.c > index 27e84ec21694..1b3479a8db5f 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c > @@ -217,7 +217,7 @@ static int vidi_ctx_initialize(struct vidi_context *ctx, > return 0; > } > > -static struct exynos_drm_crtc_ops vidi_crtc_ops = { > +static const struct exynos_drm_crtc_ops vidi_crtc_ops = { > .dpms = vidi_dpms, > .enable_vblank = vidi_enable_vblank, > .disable_vblank = vidi_disable_vblank, > diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c > index fbec750574e6..d4afd1abe373 100644 > --- a/drivers/gpu/drm/exynos/exynos_mixer.c > +++ b/drivers/gpu/drm/exynos/exynos_mixer.c > @@ -1126,7 +1126,7 @@ int mixer_check_mode(struct drm_display_mode *mode) > return -EINVAL; > } > > -static struct exynos_drm_crtc_ops mixer_crtc_ops = { > +static const struct exynos_drm_crtc_ops mixer_crtc_ops = { > .dpms = mixer_dpms, > .enable_vblank = mixer_enable_vblank, > .disable_vblank = mixer_disable_vblank, > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754124AbbEKN3d (ORCPT ); Mon, 11 May 2015 09:29:33 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:10276 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751023AbbEKN32 convert rfc822-to-8bit (ORCPT ); Mon, 11 May 2015 09:29:28 -0400 X-AuditID: cbfee691-f79ca6d00000456a-df-5550aeb552b6 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <5550AEB5.4020709@samsung.com> Date: Mon, 11 May 2015 22:29:25 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 To: Krzysztof Kozlowski Cc: Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , David Airlie , Kukjin Kim , Jingoo Han , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Javier Martinez Canillas , Krzysztof Kozlowski Subject: Re: [RFT PATCH v2 2/3] drm/exynos: Constify exynos_drm_crtc_ops References: <1430957086-25005-1-git-send-email-k.kozlowski@samsung.com> <1430957086-25005-3-git-send-email-k.kozlowski@samsung.com> In-reply-to: <1430957086-25005-3-git-send-email-k.kozlowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrKIsWRmVeSWpSXmKPExsWyRsSkQHfbuoBQg4MCFr3nTjJZXPn6ns3i 6O8Ci8sLL7FavLh3kcXi+b8f7BavXxha9D9+zWxxtukNu8Wmx9dYLS7vmsNmMeP8PiaLGZNf sjnwevx9fp3FY+esu+wem1Z1snls//aA1eN+93Emj81L6j36tqxi9Pi8SS6AI4rLJiU1J7Ms tUjfLoErY8Gn6+wFM7Urbq5exNjAeFO5i5GTQ0LARKL5WhsrhC0mceHeerYuRi4OIYGljBLv Jx9lgyma820aO4gtJDCdUeL5xwwQm1dAUOLH5HssIDazgLrEpHmLmCFsEYnNTW2MELa2xLKF r5khht5nlPix8RUTRLOWxPwNd8CGsgioSuzq+Q7WwAZkT1xxH2yxqECYxItXu8CGiggYShzc vZ0JZBCzwCNmiT13pwGdzcEhLOAhceqoIcSCVkaJ7f2bwYZyAsXfHrrOCJKQEJjIIbHj+142 iG0CEt8mH2IBaZYQkJXYdIAZ4ktJiYMrbrBMYBSfheS5WUiem4XkuVlInlvAyLKKUTS1ILmg OCm9yFSvODG3uDQvXS85P3cTIzD2T/97NnEH4/0D1ocYBTgYlXh4Oy75hwqxJpYVV+YeYjQF umgis5Rocj4wweSVxBsamxlZmJqYGhuZW5opifPqSP8MFhJITyxJzU5NLUgtii8qzUktPsTI xMEp1cCoetVW8uLNpoKX23dJZ7ypYD3kOIt3vv2RkHeJmv0t+e1v76x/93Nhn0OObOmLK4/m pW1XdRbNDrfl9jt47nCLklgrq1Xd15kXrnj8ufv3/vF2BcF8Lp+LZYevsH6+FPuJJWnVU77+ xyt7JWXkssqduv7de7xk7x/u3Vcbd7Iw2z+/lOhiZLVTiaU4I9FQi7moOBEAi5ruHfgCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGKsWRmVeSWpSXmKPExsVy+t9jQd2t6wJCDU5vMLPoPXeSyeLK1/ds Fkd/F1hcXniJ1eLFvYssFs///WC3eP3C0KL/8Wtmi7NNb9gtNj2+xmpxedccNosZ5/cxWcyY /JLNgdfj7/PrLB47Z91l99i0qpPNY/u3B6we97uPM3lsXlLv0bdlFaPH501yARxRDYw2GamJ KalFCql5yfkpmXnptkrewfHO8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUAXKymUJeaUAoUC EouLlfTtME0IDXHTtYBpjND1DQmC6zEyQAMJaxgzNrTPZC24r1WxoHcPewPjfOUuRk4OCQET iTnfprFD2GISF+6tZwOxhQSmM0o8/5gBYvMKCEr8mHyPpYuRg4NZQF7iyKVskDCzgLrEpHmL mLsYuYDK7zNK/Nj4igmiXkti/oY7YDNZBFQldvV8ZwSx2YDsiSvug80XFQiTePFqFzOILSJg KHFw93YmkEHMAo+YJfbcncYKskxYwEPi1FFDiAWtjBLb+zeDDeUEir89dJ1xAqPALCT3zUK4 bxaS+xYwMq9iFE0tSC4oTkrPNdQrTswtLs1L10vOz93ECE4Tz6R2MK5ssDjEKMDBqMTD23HJ P1SINbGsuDL3EKMEB7OSCK/ymoBQId6UxMqq1KL8+KLSnNTiQ4ymQN9NZJYSTc4HprC8knhD YxMzI0sjc0MLI2NzJXHek/k+oUIC6YklqdmpqQWpRTB9TBycUg2MWsb3Xm1sXGaipqQRvNbh 8HuzhA4xF21btS0s++0n3z26Kyni/Q77oheGm8x/RHZtvXz50iqLSwLfP1dwnxIsMfMKO5tZ 319zyTcglfGx8fOFPzIPTnhmo/fw0yfeP/+OevmJvNo+78vNwPbND2Q6+w33icUu3y286JqD gaEIq95V7RixqKofSizFGYmGWsxFxYkAjyFMvSkDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015년 05월 07일 09:04, Krzysztof Kozlowski wrote: > From: Krzysztof Kozlowski > > The Exynos DRM code does not modify the ops provided by CRTC driver in > exynos_drm_crtc_create() call. Please check coding style with checkpatch.pl before posting it. I can see below warning, WARNING: line over 80 characters #146: FILE: drivers/gpu/drm/exynos/exynos_drm_crtc.c:244: + const struct exynos_drm_crtc_ops *ops, WARNING: line over 80 characters #159: FILE: drivers/gpu/drm/exynos/exynos_drm_crtc.h:24: + const struct exynos_drm_crtc_ops *ops, I modified and merged all patches. Thanks, Inki Dae > > Signed-off-by: Krzysztof Kozlowski > > --- > Changes since v1: > New patch. > --- > drivers/gpu/drm/exynos/exynos7_drm_decon.c | 2 +- > drivers/gpu/drm/exynos/exynos_drm_crtc.c | 2 +- > drivers/gpu/drm/exynos/exynos_drm_crtc.h | 2 +- > drivers/gpu/drm/exynos/exynos_drm_drv.h | 2 +- > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +- > drivers/gpu/drm/exynos/exynos_drm_vidi.c | 2 +- > drivers/gpu/drm/exynos/exynos_mixer.c | 2 +- > 7 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos7_drm_decon.c b/drivers/gpu/drm/exynos/exynos7_drm_decon.c > index 1f7e33f59de6..3d00df76220d 100644 > --- a/drivers/gpu/drm/exynos/exynos7_drm_decon.c > +++ b/drivers/gpu/drm/exynos/exynos7_drm_decon.c > @@ -710,7 +710,7 @@ static void decon_dpms(struct exynos_drm_crtc *crtc, int mode) > } > } > > -static struct exynos_drm_crtc_ops decon_crtc_ops = { > +static const struct exynos_drm_crtc_ops decon_crtc_ops = { > .dpms = decon_dpms, > .mode_fixup = decon_mode_fixup, > .commit = decon_commit, > diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c > index eb49195cec5c..93f873f11f64 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c > @@ -241,7 +241,7 @@ struct exynos_drm_crtc *exynos_drm_crtc_create(struct drm_device *drm_dev, > struct drm_plane *plane, > int pipe, > enum exynos_drm_output_type type, > - struct exynos_drm_crtc_ops *ops, > + const struct exynos_drm_crtc_ops *ops, > void *ctx) > { > struct exynos_drm_crtc *exynos_crtc; > diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.h b/drivers/gpu/drm/exynos/exynos_drm_crtc.h > index 0ecd8fc45cff..ed0994b3cb47 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.h > +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.h > @@ -21,7 +21,7 @@ struct exynos_drm_crtc *exynos_drm_crtc_create(struct drm_device *drm_dev, > struct drm_plane *plane, > int pipe, > enum exynos_drm_output_type type, > - struct exynos_drm_crtc_ops *ops, > + const struct exynos_drm_crtc_ops *ops, > void *context); > int exynos_drm_crtc_enable_vblank(struct drm_device *dev, int pipe); > void exynos_drm_crtc_disable_vblank(struct drm_device *dev, int pipe); > diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exynos/exynos_drm_drv.h > index 44f128a03aea..0e951226ca06 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_drv.h > +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h > @@ -226,7 +226,7 @@ struct exynos_drm_crtc { > unsigned int dpms; > wait_queue_head_t pending_flip_queue; > struct drm_pending_vblank_event *event; > - struct exynos_drm_crtc_ops *ops; > + const struct exynos_drm_crtc_ops *ops; > void *ctx; > }; > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > index 2fb95ccb5841..5c1a148525f8 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > @@ -962,7 +962,7 @@ static void fimd_dp_clock_enable(struct exynos_drm_crtc *crtc, bool enable) > writel(DP_MIE_CLK_DP_ENABLE, ctx->regs + DP_MIE_CLKCON); > } > > -static struct exynos_drm_crtc_ops fimd_crtc_ops = { > +static const struct exynos_drm_crtc_ops fimd_crtc_ops = { > .dpms = fimd_dpms, > .mode_fixup = fimd_mode_fixup, > .commit = fimd_commit, > diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exynos/exynos_drm_vidi.c > index 27e84ec21694..1b3479a8db5f 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c > @@ -217,7 +217,7 @@ static int vidi_ctx_initialize(struct vidi_context *ctx, > return 0; > } > > -static struct exynos_drm_crtc_ops vidi_crtc_ops = { > +static const struct exynos_drm_crtc_ops vidi_crtc_ops = { > .dpms = vidi_dpms, > .enable_vblank = vidi_enable_vblank, > .disable_vblank = vidi_disable_vblank, > diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c > index fbec750574e6..d4afd1abe373 100644 > --- a/drivers/gpu/drm/exynos/exynos_mixer.c > +++ b/drivers/gpu/drm/exynos/exynos_mixer.c > @@ -1126,7 +1126,7 @@ int mixer_check_mode(struct drm_display_mode *mode) > return -EINVAL; > } > > -static struct exynos_drm_crtc_ops mixer_crtc_ops = { > +static const struct exynos_drm_crtc_ops mixer_crtc_ops = { > .dpms = mixer_dpms, > .enable_vblank = mixer_enable_vblank, > .disable_vblank = mixer_disable_vblank, >