All of lore.kernel.org
 help / color / mirror / Atom feed
From: michal.simek@xilinx.com (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net: ll_temac: Use one return statement instead of two
Date: Mon, 11 May 2015 16:05:33 +0200	[thread overview]
Message-ID: <5550B72D.2020004@xilinx.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1505071730090.2462@hadrien>

On 05/07/2015 05:30 PM, Julia Lawall wrote:
> On Thu, 7 May 2015, Michal Simek wrote:
> 
>> From: Michal Simek <monstr@monstr.eu>
>>
>> Use one return statement instead of two to simplify the code.
>> Both are returning the same value.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> 
> The from should be the same as the signed off.  You need From if you want
> something different than what is naturally put by your mailer.  But that
> doesn't see to be the case.

ok. Fixed in v2.

Thanks,
Michal

WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <michal.simek@xilinx.com>
To: Julia Lawall <julia.lawall@lip6.fr>,
	Michal Simek <michal.simek@xilinx.com>
Cc: netdev@vger.kernel.org, "Michal Simek" <monstr@monstr.eu>,
	"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
	"Fabian Frederick" <fabf@skynet.be>,
	linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	"Manuel Schölling" <manuel.schoelling@gmx.de>,
	"Markus Elfring" <elfring@users.sourceforge.net>,
	"Subbaraya Sundeep Bhatta" <subbaraya.sundeep.bhatta@xilinx.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] net: ll_temac: Use one return statement instead of two
Date: Mon, 11 May 2015 16:05:33 +0200	[thread overview]
Message-ID: <5550B72D.2020004@xilinx.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1505071730090.2462@hadrien>

On 05/07/2015 05:30 PM, Julia Lawall wrote:
> On Thu, 7 May 2015, Michal Simek wrote:
> 
>> From: Michal Simek <monstr@monstr.eu>
>>
>> Use one return statement instead of two to simplify the code.
>> Both are returning the same value.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> 
> The from should be the same as the signed off.  You need From if you want
> something different than what is naturally put by your mailer.  But that
> doesn't see to be the case.

ok. Fixed in v2.

Thanks,
Michal


  reply	other threads:[~2015-05-11 14:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-07 13:29 [PATCH] net: ll_temac: Use one return statement instead of two Michal Simek
2015-05-07 13:29 ` Michal Simek
2015-05-07 15:30 ` Julia Lawall
2015-05-07 15:30   ` Julia Lawall
2015-05-11 14:05   ` Michal Simek [this message]
2015-05-11 14:05     ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5550B72D.2020004@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.