From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC PATCH v2 09/22] xen/arm: its: Add helper functions to decode ITS Command Date: Mon, 11 May 2015 15:25:41 +0100 Message-ID: <5550BBE5.6050201@citrix.com> References: <1426775889-29442-1-git-send-email-vijay.kilari@gmail.com> <1426775889-29442-10-git-send-email-vijay.kilari@gmail.com> <1427888430.2115.275.camel@citrix.com> <5550BBBD.6080802@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5550BBBD.6080802@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , Vijay Kilari , Ian Campbell Cc: Stefano Stabellini , Prasun Kapoor , Vijaya Kumar K , Julien Grall , Tim Deegan , "xen-devel@lists.xen.org" , Stefano Stabellini , manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org On 11/05/15 15:25, Julien Grall wrote: > Hi Vijay, > > On 11/05/15 15:14, Vijay Kilari wrote: >> On Wed, Apr 1, 2015 at 5:10 PM, Ian Campbell wrote: >>> On Thu, 2015-03-19 at 20:07 +0530, vijay.kilari@gmail.com wrote: >>>> From: Vijaya Kumar K >>>> >>>> Add helper functions to decode ITS command >>>> This will be useful for Virtual ITS driver >>> >>> It depends slightly on the answer to the quesiton I asked on patch #6, >>> but in general in Xen we have preferred to define a structure/union >>> overlaying the processor's view of such things and to use access to >>> those fields, see e.g. the hsr decode or the pte stuff. >> >> This make heavy and simple changes. I prefer to make it a separate >> patch series. > > We are at early stage of the review process, it's the second version and > the design is not yet set in stone. So it's normal to have heavy changes > in the code between 2 versions. > > Although, when you say heavy, it's compare to what? The GICv3 ITS driver? * from Linux? -- Julien Grall