From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH v2 1/8] xenalyze: add to
	tools/xentrace/xenalyze
Date: Mon, 11 May 2015 15:33:11 +0100
Message-ID: <5550BDA7.7020008@eu.citrix.com>
References: <1430994944-20471-1-git-send-email-olaf@aepfle.de>
	<1430994944-20471-2-git-send-email-olaf@aepfle.de>
	<CAFLBxZZhdithXj2BvGsvSY7jAahsCMxJua7x7+y-kbdBH4cm7A@mail.gmail.com>
	<20150511141515.GA14629@aepfle.de>
	<1431354212.8263.65.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1431354212.8263.65.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, Olaf Hering <olaf@aepfle.de>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 05/11/2015 03:23 PM, Ian Campbell wrote:
> On Mon, 2015-05-11 at 16:15 +0200, Olaf Hering wrote:
>> On Thu, May 07, George Dunlap wrote:
>>
>>> On Thu, May 7, 2015 at 11:35 AM, Olaf Hering <olaf@aepfle.de> wrote:
>>
>>>>  tools/xentrace/xenalyze/Makefile   |    21 +
>>
>>> I personally think it would make more sense to just put the xenalyze
>>> directory in tools/.
> 
> What (if anything) is the relationship between xentrace and xenalyze?
> 
> I think the latter post processes the result of the former, is that
> right?

Yes.  So someone might argue that, both having to do with the xen
tracing system, they should live in the same directory; that's where
xentrace_format lives, after all.

However, all xentrace does is basically map the hypervisor buffers and
dump them to disk.  Other than that, there is no functional overlap
between them.

It looks like olaf is only checking in the core xenalyze binary, not the
other side bits (like the html documentation), so keeping them in the
same directory might make sense.

 -George