Re: [Qemu-devel] [PATCH v2 2/7] disas: QOMify target specific setup

[Richard Henderson <rth@twiddle.net>]

On 05/11/2015 07:46 AM, Paolo Bonzini wrote:
> 
> 
> On 09/05/2015 22:11, Peter Crosthwaite wrote:
>> @@ -198,6 +199,8 @@ static int print_insn_od_target(bfd_vma pc, disassemble_info *info)
>>  void target_disas(FILE *out, CPUArchState *env, target_ulong code,
>>                    target_ulong size, int flags)
>>  {
>> +    CPUState *cpu = ENV_GET_CPU(env);
>> +    CPUClass *cc = CPU_GET_CLASS(cpu);
>>      target_ulong pc;
>>      int count;
>>      CPUDebug s;
>> @@ -215,6 +218,11 @@ void target_disas(FILE *out, CPUArchState *env, target_ulong code,
>>  #else
>>      s.info.endian = BFD_ENDIAN_LITTLE;
>>  #endif
>> +
>> +    if (cc->disas_set_info) {
>> +        cc->disas_set_info(cpu, &s.info);
>> +    }
>> +
>>  #if defined(TARGET_I386)
> 
> Perhaps pass down the flags too?

The hook is allowing us to ditch the flags.  See 4/7 and 7/7 for arm and cris
portions that do exactly that.


r~