From: guohanjun@huawei.com (Hanjun Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM64: kernel: make cpu_ops hooks DT agnostic
Date: Tue, 12 May 2015 09:31:31 +0800 [thread overview]
Message-ID: <555157F3.8040404@huawei.com> (raw)
In-Reply-To: <20150511160401.GC4595@leverpostej>
On 2015/5/12 0:04, Mark Rutland wrote:
> Hi Lorenzo,
>
>> /**
>> * struct cpu_operations - Callback operations for hotplugging CPUs.
>> *
>> - * @name: Name of the property as appears in a devicetree cpu node's
>> - * enable-method property.
>> - * @cpu_init: Reads any data necessary for a specific enable-method from the
>> - * devicetree, for a given cpu node and proposed logical id.
>> + * @name: Name of the enable-method.
> I'm not keen on dropping the DT portion from the name documentation,
> given the name must be the DT enable-method string. I'd prefer to leave
> the original comment, or something at least mentioning that the name is
> a DT enable-method string.
>
> Other than that, this patch looks fine to me, and I don't see issues
> booting on a (DT) system, so:
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Tested-by: Mark Rutland <mark.rutland@arm.com> [DT]
>
> Has this has been tested on an ACPI system?
I will test and review this patch set today, thanks.
Hanjun
next prev parent reply other threads:[~2015-05-12 1:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 17:34 [PATCH 1/2] ARM64: kernel: make cpu_ops hooks DT agnostic Lorenzo Pieralisi
2015-05-07 17:34 ` [PATCH 2/2] ARM64: kernel: unify ACPI and DT cpus initialization Lorenzo Pieralisi
2015-05-11 16:29 ` Mark Rutland
2015-05-12 10:37 ` Lorenzo Pieralisi
2015-05-11 16:04 ` [PATCH 1/2] ARM64: kernel: make cpu_ops hooks DT agnostic Mark Rutland
2015-05-12 1:31 ` Hanjun Guo [this message]
2015-05-12 10:45 ` Lorenzo Pieralisi
2015-05-12 13:43 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555157F3.8040404@huawei.com \
--to=guohanjun@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.