From: Robert Yang <liezhi.yang@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 10/12] packagegroup-core-qt: add x11 to REQUIRED_DISTRO_FEATURES
Date: Tue, 12 May 2015 10:51:21 +0800 [thread overview]
Message-ID: <55516AA9.2050003@windriver.com> (raw)
In-Reply-To: <CAJTo0LYZj2hottHmqHUDFH80Y+6Q-0fbtYLZepe86AdtZ33z5g@mail.gmail.com>
On 05/11/2015 07:43 PM, Burton, Ross wrote:
>
> On 11 May 2015 at 07:08, Robert Yang <liezhi.yang@windriver.com
> <mailto:liezhi.yang@windriver.com>> wrote:
>
> +# The quicky and fotowall requires x11 in DISTRO_FEATURES
> +REQUIRED_DISTRO_FEATURES = "x11"
>
>
> As this is a helper packagegroup, would it make sense to have these as optional
> dependencies based on DISTRO_FEATURES instead?
Hi Ross,
The packagegroup-core-qt RDEPENDS on 3 packages:
QTDEMOS ?= "quicky ${COMMERCIAL_QT} fotowall"
Both quicky and fotowall requires x11. The COMMERCIAL_QT(such as qmmp)
requires commercial license, I think that it also requires x11 (I will
fix it in other patches). Use optional dependencies based on
DISTRO_FEATURES for packagegroup-core-qt would make it rdepends on nothing,
so I didn't use that.
// Robert
>
> Ross
next prev parent reply other threads:[~2015-05-12 2:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 6:08 [PATCH 00/12] make world build work without x11 in DISTRO_FEATURES Robert Yang
2015-05-11 6:08 ` [PATCH 01/12] mesa: fix do_install_append Robert Yang
2015-05-11 6:08 ` [PATCH 02/12] gtk+/cairo: enable x11 or directfb Robert Yang
2015-05-15 2:06 ` Robert Yang
2015-05-11 6:08 ` [PATCH 03/12] mesa-demos: only enable glu when x11 in DISTRO_FEATURES Robert Yang
2015-05-11 6:08 ` [PATCH 04/12] libglu: add x11 to REQUIRED_DISTRO_FEATURES Robert Yang
2015-05-11 6:08 ` [PATCH 05/12] libsdl: depends on libglu when x11 Robert Yang
2015-05-15 19:59 ` Burton, Ross
2015-05-15 20:00 ` Burton, Ross
2015-06-03 5:32 ` Robert Yang
2015-05-11 6:08 ` [PATCH 06/12] libowl/settings-daemon/libnotify: add x11 to REQUIRED_DISTRO_FEATURES Robert Yang
2015-05-11 6:08 ` [PATCH 07/12] recipes-extended: " Robert Yang
2015-05-11 6:08 ` [PATCH 08/12] recipes-graphics: " Robert Yang
2015-05-11 6:08 ` [PATCH 09/12] gst-plugins-gl: " Robert Yang
2015-05-11 6:08 ` [PATCH 10/12] packagegroup-core-qt: " Robert Yang
2015-05-11 11:43 ` Burton, Ross
2015-05-12 2:51 ` Robert Yang [this message]
2015-05-11 6:08 ` [PATCH 11/12] recipes-sato: " Robert Yang
2015-05-11 6:08 ` [PATCH 12/12] at-spi2-atk: " Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55516AA9.2050003@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.