From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e39.co.us.ibm.com ([32.97.110.160]:54381 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752453AbbELGHQ (ORCPT ); Tue, 12 May 2015 02:07:16 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 12 May 2015 00:07:16 -0600 Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 37B6D6E803F for ; Tue, 12 May 2015 01:59:01 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t4C67CQ644040212 for ; Tue, 12 May 2015 06:07:12 GMT Received: from d01av01.pok.ibm.com (localhost [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t4C67C95029205 for ; Tue, 12 May 2015 02:07:12 -0400 Message-ID: <5551988D.4060002@linux.vnet.ibm.com> Date: Tue, 12 May 2015 11:37:09 +0530 From: Preeti U Murthy MIME-Version: 1.0 To: Guenter Roeck , Greg Kroah-Hartman CC: stable , Ingo Molnar Subject: Re: 4.0.2-stable-queue build failures due to 'clockevents: Fix cpu_down() race for hrtimer based broadcasting' References: <554FFEED.6030308@roeck-us.net> <55504319.9090501@linux.vnet.ibm.com> <20150511130234.GA24321@roeck-us.net> In-Reply-To: <20150511130234.GA24321@roeck-us.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 05/11/2015 06:32 PM, Guenter Roeck wrote: > On Mon, May 11, 2015 at 11:20:17AM +0530, Preeti U Murthy wrote: >> On 05/11/2015 06:29 AM, Guenter Roeck wrote: >>> Build is still going on, so there may be other affected architectures. >>> >>> --- >>> >>> Building ia64:defconfig ... failed >>> Building parisc:generic-32bit_defconfig ... failed >>> -------------- >>> Error log: >>> kernel/cpu.c: In function '_cpu_down': >>> kernel/cpu.c:415:2: error: implicit declaration of function >>> 'hotplug_cpu__broadcast_tick_pull' [-Werror=implicit-function-declaration] >>> cc1: some warnings being treated as errors >>> > [ ... ] > >>> git bisect good c20b6545f649724a733e008e7124fa9d1e114c71 >>> # first bad commit: [c71309a3658d323d56261d4590b2c5214e61b05f] >>> clockevents: Fix cpu_down() race for hrtimer based broadcasting >>> >>> --- >>> >>> Reverting the bad commit fixes the problem. >> >> Please let me know if the following patch fixes the issue: >> >> clockevents: Fix build error caused by fix for hotplug race with hrtimer broadcast >> >> commit: c71309a3658d ("clockevents: Fix cpu_down() race for hrtimer based broadcasting") >> causes a build error on certain archs where CONFIG_GENERIC_CLOCKEVENTS >> is not set. This patch fixes this. >> >> +++ b/include/linux/tick.h >> @@ -134,6 +134,7 @@ static inline void tick_clock_notify(void) { } >> static inline int tick_check_oneshot_change(int allow_nohz) { return 0; } >> static inline void tick_irq_enter(void) { } >> static inline int tick_oneshot_mode_active(void) { return 0; } >> +static inline void hotplug_cpu__broadcast_tick_pull(int dead_cpu) { } > > Possibly it does, but why is the back-port so much different from the original > patch ? This would be the third declaration of this dummy function, which just > seems wrong. The original patch only needs one. That is because these two patches simplified the layout of the related files. c1797baf6880174: tick: Move core only declarations and functions to core b7475eb599ddb2e: tick: Simplify tick-internal.h These patches are not yet in stable. Regards Preeti U Murthy > > Guenter >