From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, "Denis V. Lunev" <den@openvz.org>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] block: align bounce buffers to page
Date: Tue, 12 May 2015 12:50:25 +0200 [thread overview]
Message-ID: <5551DAF1.1010009@redhat.com> (raw)
In-Reply-To: <20150512102709.GB3696@noname.str.redhat.com>
On 12/05/2015 12:27, Kevin Wolf wrote:
> I think it would make more sense to keep this specific to the raw-posix
> driver. After all, it's only the kernel page cache that we optimise
> here. Other backends probably don't take advantage of page alignment.
I don't think it makes sense to keep it raw-posix-specific, though.
It's not the page cache that we optimize for, because this is with
O_DIRECT. If anything, making it page aligned means that the buffer
spans one fewer physical page and thus it may economize a bit on TLB misses.
Paolo
next prev parent reply other threads:[~2015-05-12 10:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 5:47 [Qemu-devel] [PATCH v6 0/2] block: enforce minimal 4096 alignment in qemu_blockalign Denis V. Lunev
2015-05-12 5:47 ` [Qemu-devel] [PATCH 1/2] block: minimal bounce buffer alignment Denis V. Lunev
2015-05-12 10:29 ` Kevin Wolf
2015-05-12 5:47 ` [Qemu-devel] [PATCH 2/2] block: align bounce buffers to page Denis V. Lunev
2015-05-12 10:27 ` Kevin Wolf
2015-05-12 10:36 ` [Qemu-devel] [Qemu-block] " Denis V. Lunev
2015-05-12 13:08 ` Kevin Wolf
2015-05-12 13:13 ` Denis V. Lunev
2015-05-12 10:50 ` Paolo Bonzini [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-05-12 14:30 [Qemu-devel] [PATCH v8 0/2] block: enforce minimal 4096 alignment in qemu_blockalign Denis V. Lunev
2015-05-12 14:30 ` [Qemu-devel] [PATCH 2/2] block: align bounce buffers to page Denis V. Lunev
2015-05-12 13:40 [Qemu-devel] [PATCH v7 0/2] block: enforce minimal 4096 alignment in qemu_blockalign Denis V. Lunev
2015-05-12 13:41 ` [Qemu-devel] [PATCH 2/2] block: align bounce buffers to page Denis V. Lunev
2015-05-12 14:08 ` Kevin Wolf
2015-05-12 14:20 ` Denis V. Lunev
2015-05-12 14:26 ` Kevin Wolf
2015-05-12 14:26 ` Denis V. Lunev
2015-05-04 13:42 [Qemu-devel] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign Denis V. Lunev
2015-05-04 13:42 ` [Qemu-devel] [PATCH 2/2] block: align bounce buffers to page Denis V. Lunev
2015-02-06 17:37 [Qemu-devel] [PATCH v4 0/1] block: enforce minimal 4096 alignment in qemu_blockalign Denis V. Lunev
2015-02-06 17:37 ` [Qemu-devel] [PATCH 2/2] block: align bounce buffers to page Denis V. Lunev
2015-02-16 10:59 ` Kevin Wolf
2015-02-16 11:14 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5551DAF1.1010009@redhat.com \
--to=pbonzini@redhat.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.