From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v3 3/6] libxc/migration: Specification
 update for CHECKPOINT records
Date: Tue, 12 May 2015 11:53:39 +0100
Message-ID: <5551DBB3.6000009@citrix.com>
References: <1431423351-27424-1-git-send-email-andrew.cooper3@citrix.com>
	<1431423351-27424-4-git-send-email-andrew.cooper3@citrix.com>
	<5551CDC1.1090107@citrix.com> <5551DACE.2030508@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5551DACE.2030508@cn.fujitsu.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Yang Hongyang <yanghy@cn.fujitsu.com>, David Vrabel <david.vrabel@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 12/05/15 11:49, Yang Hongyang wrote:
> Hi Andrew, David,
>
>   Would you mind if I fix the comments, and combine this series with mine
> prepare patches for Remus, and then send it out together?

Go for it.  I am happy with Davids corrections.

~Andrew

>
> On 05/12/2015 05:54 PM, David Vrabel wrote:
>> On 12/05/15 10:35, Andrew Cooper wrote:
>>> Checkpointed streams need to signal the end of a consistent view of
>>> VM state,
>>> and the start of the libxl data.
>> [...]
>>> --- a/docs/specs/libxc-migration-stream.pandoc
>>> +++ b/docs/specs/libxc-migration-stream.pandoc
>> [...]
>>> @@ -578,6 +578,23 @@ The verify record contains no fields; its
>>> body_length is 0.
>>>
>>>   \clearpage
>>>
>>> +CHECKPOINT
>>> +----------
>>> +
>>> +A checkpoint record indicates that the records thusfar in the
>>> stream represent
>>
>> ...that all the preceding records in the stream represent...
>>
>>> +a consistent view of VM state.
>>
>>> +
>>> +     0     1     2     3     4     5     6     7 octet
>>> +    +-------------------------------------------------+
>>> +
>>> +The checkpoint record contains no fields; its body_length is 0
>>> +
>>> +A stream containing checkpoint records must have indicated itself as a
>>> +checkpointed stream in the Image Header.  Conversely, a stream not
>>> identified
>>> +as checkpointed must not contain checkpoint records.
>>
>> This paragraph is stale.
>>
>> I think you should expand a bit more on this record.  Perhaps:
>>
>>    If the stream is embedded in a higher level toolstack stream, the
>>    CHECKPOINT record marks the end of the libxc portion of the stream
>>    and the stream is handed back to the higher level for further
>>    processing.
>>
>>    The higher level stream may then hand the stream back to libxc to
>>    process another set of records for the next consistent VM state
>>    snapshot.  This next set of records may be terminated by another
>>    CHECKPOINT record or an END record.
>>
>> David
>> .
>>
>