From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCHv7 3/3] gnttab: use per-VCPU maptrack free
 lists
Date: Tue, 12 May 2015 13:37:12 +0100
Message-ID: <5551F3F8.7070602@citrix.com>
References: <1430400525-31064-1-git-send-email-david.vrabel@citrix.com>
	<1430400525-31064-4-git-send-email-david.vrabel@citrix.com>
	<5548D4F60200007800076AA9@mail.emea.novell.com>
	<5551DD79.40507@citrix.com>
	<5552022902000078000796A4@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <david.vrabel@citrix.com>) id 1Ys9Rr-0002E4-5K
	for xen-devel@lists.xenproject.org; Tue, 12 May 2015 12:38:11 +0000
In-Reply-To: <5552022902000078000796A4@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Christoph Egger <chegger@amazon.de>, Tim Deegan <tim@xen.org>, Matt Wilson <msw@amazon.com>, xen-devel@lists.xenproject.org, Malcolm Crossley <malcolm.crossley@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 12/05/15 12:37, Jan Beulich wrote:
>>>> On 12.05.15 at 13:01, <david.vrabel@citrix.com> wrote:
>> On 05/05/15 13:34, Jan Beulich wrote:
>>>>>> On 30.04.15 at 15:28, <david.vrabel@citrix.com> wrote:
>>>> @@ -1430,6 +1456,17 @@ gnttab_setup_table(
>>>>      gt = d->grant_table;
>>>>      write_lock(&gt->lock);
>>>>  
>>>> +    /* Tracking of mapped foreign frames table */
>>>> +    if ( (gt->maptrack = xzalloc_array(struct grant_mapping *,
>>>> +                                       max_maptrack_frames * d->max_vcpus)) == NULL )
>>>> +        goto out3;
>>>
>>> This surely can easily become an allocation of far more than a page,
>>> and hence needs to be broken up (perhaps using vmap() to map
>>> individually allocated pages).
>>
>> I think there should be a common vzalloc_array() function.  Do you
>> agree?  This will use xzalloc_array() if the alloc is < PAGE_SIZE to
>> avoid needlessly using vmap space.
> 
> For the _array flavor I'm not sure, but vmalloc()/vzalloc() are
> already in the process of being added.

Can I leave this as-is (with the xzalloc_array()) and fix it up once
vzalloc() exists?

David