From mboxrd@z Thu Jan  1 00:00:00 1970
From: Razvan Cojocaru <rcojocaru@bitdefender.com>
Subject: Re: [PATCH] xen/vm_event: Clean up
 control-register-write vm_events
Date: Tue, 12 May 2015 18:49:46 +0300
Message-ID: <5552211A.3040706@bitdefender.com>
References: <1431442725-18395-1-git-send-email-rcojocaru@bitdefender.com>
	<555239EE020000780007998A@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <555239EE020000780007998A@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: kevin.tian@intel.com, wei.liu2@citrix.com, eddie.dong@intel.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, tim@xen.org, xen-devel@lists.xen.org, jun.nakajima@intel.com, keir@xen.org, ian.jackson@eu.citrix.com, ian.campbell@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 05/12/2015 06:35 PM, Jan Beulich wrote:
>>>> On 12.05.15 at 16:58, <rcojocaru@bitdefender.com> wrote:
>> +/* Supported values for the vm_event_write_ctrlreg index. */
>> +#define X86_CR0     (1 << 0)
>> +#define X86_CR3     (1 << 1)
>> +#define X86_CR4     (1 << 2)
>> +#define X86_XCR0    (1 << 3)
> 
> These names, being put in the public interface, are way too generic.

I've copied them from Andrew Cooper's suggestion in the previous thread,
hopefully he'll chime in. I'm happy to rename / move them if so desired.


Thanks,
Razvan