From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Razvan Cojocaru <rcojocaru@bitdefender.com>,
Jan Beulich <JBeulich@suse.com>
Cc: kevin.tian@intel.com, wei.liu2@citrix.com,
ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com,
tim@xen.org, eddie.dong@intel.com, xen-devel@lists.xen.org,
jun.nakajima@intel.com, keir@xen.org, ian.jackson@eu.citrix.com
Subject: Re: [PATCH] xen/vm_event: Clean up control-register-write vm_events
Date: Tue, 12 May 2015 16:50:38 +0100 [thread overview]
Message-ID: <5552214E.1010004@citrix.com> (raw)
In-Reply-To: <5552211A.3040706@bitdefender.com>
On 12/05/15 16:49, Razvan Cojocaru wrote:
> On 05/12/2015 06:35 PM, Jan Beulich wrote:
>>>>> On 12.05.15 at 16:58, <rcojocaru@bitdefender.com> wrote:
>>> +/* Supported values for the vm_event_write_ctrlreg index. */
>>> +#define X86_CR0 (1 << 0)
>>> +#define X86_CR3 (1 << 1)
>>> +#define X86_CR4 (1 << 2)
>>> +#define X86_XCR0 (1 << 3)
>> These names, being put in the public interface, are way too generic.
> I've copied them from Andrew Cooper's suggestion in the previous thread,
> hopefully he'll chime in. I'm happy to rename / move them if so desired.
I intended something like VM_EVENT_ARCH_X86_CR0 etc.
~Andrew
next prev parent reply other threads:[~2015-05-12 15:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 14:58 [PATCH] xen/vm_event: Clean up control-register-write vm_events Razvan Cojocaru
2015-05-12 15:35 ` Jan Beulich
2015-05-12 15:49 ` Razvan Cojocaru
2015-05-12 15:50 ` Andrew Cooper [this message]
2015-05-12 15:53 ` Andrew Cooper
2015-05-12 16:52 ` Razvan Cojocaru
2015-05-12 17:54 ` Andrew Cooper
2015-05-12 18:38 ` Razvan Cojocaru
2015-05-13 6:06 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5552214E.1010004@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=eddie.dong@intel.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=rcojocaru@bitdefender.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.