From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] xen/vm_event: Clean up control-register-write vm_events Date: Tue, 12 May 2015 16:53:56 +0100 Message-ID: <55522214.3030807@citrix.com> References: <1431442725-18395-1-git-send-email-rcojocaru@bitdefender.com> <555239EE020000780007998A@mail.emea.novell.com> <5552211A.3040706@bitdefender.com> <5552214E.1010004@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5552214E.1010004@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Razvan Cojocaru , Jan Beulich Cc: kevin.tian@intel.com, wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, eddie.dong@intel.com, tim@xen.org, xen-devel@lists.xen.org, jun.nakajima@intel.com, keir@xen.org, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 12/05/15 16:50, Andrew Cooper wrote: > On 12/05/15 16:49, Razvan Cojocaru wrote: >> On 05/12/2015 06:35 PM, Jan Beulich wrote: >>>>>> On 12.05.15 at 16:58, wrote: >>>> +/* Supported values for the vm_event_write_ctrlreg index. */ >>>> +#define X86_CR0 (1 << 0) >>>> +#define X86_CR3 (1 << 1) >>>> +#define X86_CR4 (1 << 2) >>>> +#define X86_XCR0 (1 << 3) >>> These names, being put in the public interface, are way too generic. >> I've copied them from Andrew Cooper's suggestion in the previous thread, >> hopefully he'll chime in. I'm happy to rename / move them if so desired. > I intended something like VM_EVENT_ARCH_X86_CR0 etc. or perhaps slightly more specific to ctrl_reg read/write. ~Andrew