All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
To: ofono@ofono.org
Subject: Re: [PATCH 1/2] cinterion: Add cinterion vendor support
Date: Tue, 12 May 2015 19:27:37 +0200	[thread overview]
Message-ID: <55523809.40209@dynamicdevices.co.uk> (raw)
In-Reply-To: <55438774.9010904@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 749 bytes --]

Hi Denis,

On 01/05/2015 16:02, Denis Kenzior wrote:
> Hi Alex,
>
> This part seems to be completely unnecessary?  At least by my reading
> of the code flow, at_cmer_set_cb is never called in the case of
> OFONO_VENDOR_CINTERION.
>
> This is not our coding style.  Please refer to doc/coding-style.txt
> and the Linux Kernel coding style document here:
> https://www.kernel.org/doc/Documentation/CodingStyle.

I've removed the check to ensure that the callback is not re-registered
accidentally and reformatted the patch-set, hopefully more in line with
your suggestions as to flow...

Thanks for the link to the ofono preferred coding style. I will make
time in the near future to take a look at this.

Best Regards,

Alex


      reply	other threads:[~2015-05-12 17:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-30 19:08 [PATCH 1/2] cinterion: Add cinterion vendor support Alex J Lennon
2015-04-30 19:08 ` [PATCH 2/2] cinterion: Replace tc65 plugin with vendor generic cinterion plugin Alex J Lennon
2015-05-01 14:05   ` Denis Kenzior
2015-05-01 21:11     ` Alex J Lennon
2015-05-01 14:02 ` [PATCH 1/2] cinterion: Add cinterion vendor support Denis Kenzior
2015-05-12 17:27   ` Alex J Lennon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55523809.40209@dynamicdevices.co.uk \
    --to=ajlennon@dynamicdevices.co.uk \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.